[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed

[GitBox <gi...@apache.org>]

eenurkka commented on code in PR #7075:
URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r968022878


##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -250,6 +250,33 @@ config MPFS_EMMCSD
 	---help---
 		Selects the MPFS eMMCSD driver.
 
+choice
+	depends on MPFS_EMMCSD && MMCSD_MMCSUPPORT
+	prompt "Configure eMMC clock speed"
+	---help---
+		Select the desired eMMC clock frequency.  This doesn't issue any CMD6 commands to
+		switch the mode at the moment.  This only changes the eMMC clock.  Not all hardware
+		support 200 MHz but the Polarfire Icicle kit does.
+
+config MPFS_EMMC_CLK_200MHZ
+	bool "EMMC CLK 200MHz"
+	default y
+	---help---
+		Set this to use 200MHz eMMC clock
+
+config MPFS_EMMC_CLK_50MHZ
+	bool "EMMC CLK 50MHz"
+	default n
+	---help---
+		Set this to use 50MHz eMMC clock
+
+config MPFS_EMMC_CLK_26MHZ
+	bool "EMMC CLK 26MHz"
+	default n
+	---help---
+		Set this to use 26MHz eMMC clock
+endchoice

Review Comment:
   In this case it'd simplify things, I agree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org