You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "IsaakKrut (via GitHub)" <gi...@apache.org> on 2024/03/06 17:51:28 UTC
[PR] 2312 Extend Notification sinks by silent period
IsaakKrut opened a new pull request, #2515:
URL: https://github.com/apache/streampipes/pull/2515
Purpose
For the following sinks: OneSignalSink, SlackSink, TelegramSink
Refactored to extend StreamPipesNotificationSink interface
Implemented migrations with the use of a common interface INotificationDataSinkMigrator
Added a unit test for INotificationDataSinkMigrator
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 2312 Extend Notification sinks by silent period
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer merged PR #2515:
URL: https://github.com/apache/streampipes/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 2312 Extend Notification sinks by silent period
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on code in PR #2515:
URL: https://github.com/apache/streampipes/pull/2515#discussion_r1515156334
##########
streampipes-extensions/streampipes-sinks-notifications-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/slack/SlackNotificationSink.java:
##########
@@ -56,10 +55,9 @@ public class SlackNotificationSink extends StreamPipesDataSink {
private String originalMessage;
@Override
- public DataSinkDescription declareModel() {
-
+ public DataSinkBuilder declareModelWithoutSilentPeriod() {
return DataSinkBuilder
- .create("org.apache.streampipes.sinks.notifications.jvm.slack", 0)
+ .create("org.apache.streampipes.sinks.notifications.jvm.slack", 1)
Review Comment:
Does it make sense to extract the ID to a public static variable so that it can be reused in the Migration classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 2312 Extend Notification sinks by silent period
Posted by "IsaakKrut (via GitHub)" <gi...@apache.org>.
IsaakKrut commented on code in PR #2515:
URL: https://github.com/apache/streampipes/pull/2515#discussion_r1515185224
##########
streampipes-extensions/streampipes-sinks-notifications-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/slack/SlackNotificationSink.java:
##########
@@ -56,10 +55,9 @@ public class SlackNotificationSink extends StreamPipesDataSink {
private String originalMessage;
@Override
- public DataSinkDescription declareModel() {
-
+ public DataSinkBuilder declareModelWithoutSilentPeriod() {
return DataSinkBuilder
- .create("org.apache.streampipes.sinks.notifications.jvm.slack", 0)
+ .create("org.apache.streampipes.sinks.notifications.jvm.slack", 1)
Review Comment:
Extracted the ids of those 3 sinks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org