You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/13 03:58:25 UTC
[GitHub] [spark] sarutak opened a new pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
sarutak opened a new pull request #31164:
URL: https://github.com/apache/spark/pull/31164
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR extends `StringTranslate` to support unicode characters whose code point >= `U+10000`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make it work with wide variety of characters.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can use `StringTranslate` with unicode characters whose code point >= `U+10000`.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New assertion added to the existing test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31164:
URL: https://github.com/apache/spark/pull/31164#discussion_r556975135
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -1065,16 +1065,19 @@ public UTF8String replace(UTF8String search, UTF8String replace) {
return buf.build();
}
- // TODO: Need to use `Code Point` here instead of Char in case the character longer than 2 bytes
- public UTF8String translate(Map<Character, Character> dict) {
+ public UTF8String translate(Map<String, String> dict) {
String srcStr = this.toString();
StringBuilder sb = new StringBuilder();
- for(int k = 0; k< srcStr.length(); k++) {
- if (null == dict.get(srcStr.charAt(k))) {
- sb.append(srcStr.charAt(k));
- } else if ('\0' != dict.get(srcStr.charAt(k))){
- sb.append(dict.get(srcStr.charAt(k)));
+ int charCount = 0;
+ for(int k = 0; k < srcStr.length(); k += charCount) {
+ int codePoint = srcStr.codePointAt(k);
+ charCount = Character.charCount(codePoint);
+ String subStr = srcStr.substring(k, k + charCount);
+ if (null == dict.get(subStr)) {
+ sb.append(subStr);
+ } else if (!"\0".equals(dict.get(subStr))) {
Review comment:
While we're here, we could probably optimize away the two calls to dict.get(subStr)
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -1065,16 +1065,19 @@ public UTF8String replace(UTF8String search, UTF8String replace) {
return buf.build();
}
- // TODO: Need to use `Code Point` here instead of Char in case the character longer than 2 bytes
- public UTF8String translate(Map<Character, Character> dict) {
+ public UTF8String translate(Map<String, String> dict) {
String srcStr = this.toString();
StringBuilder sb = new StringBuilder();
- for(int k = 0; k< srcStr.length(); k++) {
- if (null == dict.get(srcStr.charAt(k))) {
- sb.append(srcStr.charAt(k));
- } else if ('\0' != dict.get(srcStr.charAt(k))){
- sb.append(dict.get(srcStr.charAt(k)));
+ int charCount = 0;
+ for(int k = 0; k < srcStr.length(); k += charCount) {
Review comment:
Nit: add a space after for
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759321411
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759297746
**[Test build #134002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134002/testReport)** for PR 31164 at commit [`9fb231e`](https://github.com/apache/spark/commit/9fb231e65c83a41ce8fce9a7298c3af8d908b934).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759915013
**[Test build #134031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134031/testReport)** for PR 31164 at commit [`0bc8e24`](https://github.com/apache/spark/commit/0bc8e241c8f245204c5edf6654ebb315f149aeeb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759904208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38618/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759868150
**[Test build #134031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134031/testReport)** for PR 31164 at commit [`0bc8e24`](https://github.com/apache/spark/commit/0bc8e241c8f245204c5edf6654ebb315f149aeeb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31164:
URL: https://github.com/apache/spark/pull/31164#discussion_r559238260
##########
File path: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
##########
@@ -465,27 +465,27 @@ public void translate() {
assertEquals(
fromString("1a2s3ae"),
fromString("translate").translate(ImmutableMap.of(
- 'r', '1',
- 'n', '2',
- 'l', '3',
- 't', '\0'
+ "r", "1",
Review comment:
The type parameter of `translate` is changed from `Map<Character, Character>` to `Map<String, String>` to support >=`U+10000` unicode characters so this change is necessary. Those characters can't be represented as `Character`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759247779
**[Test build #133994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133994/testReport)** for PR 31164 at commit [`045c141`](https://github.com/apache/spark/commit/045c1414f826bff0d2c62a5dd83972ecdd8f40e6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759852761
cc @srowen FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759390906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759920095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31164:
URL: https://github.com/apache/spark/pull/31164#discussion_r559237210
##########
File path: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
##########
@@ -465,27 +465,27 @@ public void translate() {
assertEquals(
fromString("1a2s3ae"),
fromString("translate").translate(ImmutableMap.of(
- 'r', '1',
- 'n', '2',
- 'l', '3',
- 't', '\0'
+ "r", "1",
Review comment:
Ah, it's a wrong change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759920095
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31164:
URL: https://github.com/apache/spark/pull/31164#discussion_r559238260
##########
File path: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
##########
@@ -465,27 +465,27 @@ public void translate() {
assertEquals(
fromString("1a2s3ae"),
fromString("translate").translate(ImmutableMap.of(
- 'r', '1',
- 'n', '2',
- 'l', '3',
- 't', '\0'
+ "r", "1",
Review comment:
The type parameter of `translate` is changed from `Map<Character, Character>` to `Map<String, String>` to support >=`U+10000` unicode characters so this change is necessary. Those characters can't be represent as `Character`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-764671661
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759360007
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759238313
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-763273501
> OK so it doesn't show up in the tests, but these code points would be more than one char?
@srowen
It's already added to `StringExpressionSuite`. For example, `\uD840\uDC0B` [here](https://github.com/apache/spark/pull/31164/files#diff-fb37dc07c90c672fb74f787b8881f0e335386d69b49c9eed065b20f4a09d5c9fR556) is one Unicode character which is needed to be represented as two `char` values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759390906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759201329
**[Test build #133994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133994/testReport)** for PR 31164 at commit [`045c141`](https://github.com/apache/spark/commit/045c1414f826bff0d2c62a5dd83972ecdd8f40e6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759263922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133994/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759360007
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759201329
**[Test build #133994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133994/testReport)** for PR 31164 at commit [`045c141`](https://github.com/apache/spark/commit/045c1414f826bff0d2c62a5dd83972ecdd8f40e6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-762317856
OK so it doesn't show up in the tests, but these code points would be more than one char? is there any easy way to add a test for this case then? that seems to be the purpose of this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759381132
**[Test build #134002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134002/testReport)** for PR 31164 at commit [`9fb231e`](https://github.com/apache/spark/commit/9fb231e65c83a41ce8fce9a7298c3af8d908b934).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759868150
**[Test build #134031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134031/testReport)** for PR 31164 at commit [`0bc8e24`](https://github.com/apache/spark/commit/0bc8e241c8f245204c5edf6654ebb315f149aeeb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31164:
URL: https://github.com/apache/spark/pull/31164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759297746
**[Test build #134002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134002/testReport)** for PR 31164 at commit [`9fb231e`](https://github.com/apache/spark/commit/9fb231e65c83a41ce8fce9a7298c3af8d908b934).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759263922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133994/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31164:
URL: https://github.com/apache/spark/pull/31164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759904208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38618/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-764671661
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759238313
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38582/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31164:
URL: https://github.com/apache/spark/pull/31164#issuecomment-759336442
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31164: [SPARK-34094][SQL] Extends StringTranslate to support unicode characters whose code point >= U+10000
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31164:
URL: https://github.com/apache/spark/pull/31164#discussion_r558933236
##########
File path: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
##########
@@ -465,27 +465,27 @@ public void translate() {
assertEquals(
fromString("1a2s3ae"),
fromString("translate").translate(ImmutableMap.of(
- 'r', '1',
- 'n', '2',
- 'l', '3',
- 't', '\0'
+ "r", "1",
Review comment:
Why do these need to be strings now? all seem to be 1 char.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org