You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "namelessssssssssss (via GitHub)" <gi...@apache.org> on 2023/08/09 08:59:10 UTC

[GitHub] [dubbo] namelessssssssssss commented on a diff in pull request #12750: Add SPI Interface ApplicationLifecycleManager for dubbo-core refactor

namelessssssssssss commented on code in PR #12750:
URL: https://github.com/apache/dubbo/pull/12750#discussion_r1288174448


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java:
##########
@@ -1088,10 +448,22 @@ public void checkState(ModuleModel moduleModel, DeployState moduleState) {
             if (!moduleModel.isInternal() && moduleState == DeployState.STARTED) {
                 prepareApplicationInstance();
             }
+            lifecycleManager.preModuleChanged(moduleModel,moduleState,hasPreparedApplicationInstance);
             DeployState newState = calculateState();
             switch (newState) {
                 case STARTED:
-                    onStarted();
+                    if (!isStarting()) {
+                        break;
+                    }
+                    try {
+                        lifecycleManager.postModuleChanged(moduleModel, moduleState, newState);

Review Comment:
   It's a mistake. I'm working on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org