You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "funes79 (via GitHub)" <gi...@apache.org> on 2023/03/07 15:25:17 UTC

[GitHub] [airflow] funes79 opened a new issue, #29957: hostAliases for scheduler and webserver

funes79 opened a new issue, #29957:
URL: https://github.com/apache/airflow/issues/29957

   ### Description
   
   I am not sure why this PR was not merged (https://github.com/apache/airflow/pull/23558) but I think it would be great to add hostAliases not just to the workers, but the scheduler and webserver too.
   
   ### Use case/motivation
   
   Be able to modify /etc/hosts in webserver and scheduler.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed issue #29957: hostAliases for scheduler and webserver

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #29957: hostAliases for scheduler and webserver
URL: https://github.com/apache/airflow/issues/29957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] amoghrajesh commented on issue #29957: hostAliases for scheduler and webserver

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #29957:
URL: https://github.com/apache/airflow/issues/29957#issuecomment-1464903330

   @potiuk @funes79 i don't mind taking it up and finishing it. Guess there's enough context too around it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] eladkal commented on issue #29957: hostAliases for scheduler and webserver

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29957:
URL: https://github.com/apache/airflow/issues/29957#issuecomment-1464903984

   @amoghrajesh assigned to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] amoghrajesh commented on issue #29957: hostAliases for scheduler and webserver

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #29957:
URL: https://github.com/apache/airflow/issues/29957#issuecomment-1465097222

   @eladkal @potiuk @funes79 Added a PR for this: https://github.com/apache/airflow/pull/30051
   Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on issue #29957: hostAliases for scheduler and webserver

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #29957:
URL: https://github.com/apache/airflow/issues/29957#issuecomment-1458363213

   Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #29957: hostAliases for scheduler and webserver

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29957:
URL: https://github.com/apache/airflow/issues/29957#issuecomment-1459064955

   @funes79  It has not been merged, because the author had not lead it to completion. Changes in airflow are implemented by > 2300 contributors - often people like you who want some change and make the effort to create a PR, pass all the tests and pass the review of the maintainers (including pinging them if needed). So if you deeply care about some thing to be implemented - the best thing you can do is to ... implement it.  When you create an issue like that, what we can do as maintainers, we can mark it as "good first issue" if it is something like that (which I did). Then, if there is someone who will pick it up and lead it to completion, and it will get merged - then it will be implemented.
   
   This is how things work here. Things get implemetned, when someone decides to care for it and implement them.
   
   So if you think you need it and do not want to wait for someone to pick it up, implementing it yourself and contributing a PR is the next best thing you can do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org