[GitHub] [incubator-zipkin] adriancole opened a new pull request #2562: Conditionally wraps in Elasticsearch index template based on version

[GitBox <gi...@apache.org>]

adriancole opened a new pull request #2562: Conditionally wraps in Elasticsearch index template based on version
URL: https://github.com/apache/incubator-zipkin/pull/2562
 
 
   Elasticsearch 7.x no longer wraps mappings by top-level type. They have
   a compatibility mode, but it complicates secondary templates as noticed
   by @chefky
   
   > For my custom index issue in elasticsearch 7.0 -- I figured it out, but I think it does have an implication with the code. You are still creating the index template with the mapping type, which ElasticSearch has deprecated in 7.0. When I do a 'GET /_template/zipkin-span_template', the mapping type 'span' is removed, and so my updated version did not include the mapping type. I can only get it to work by including the mapping type 'span' in my updated index template, but I have to append 'includeTypeName=true' in the URL, which then results in a message from ElasticSearch indicating that this is deprecated and that they will not support this in the next major version. Do you also use 'includeTypeName=true' when creating the span index template in ElasticSearch? Because I tried to edit the source code to remove the mapping type, but I was getting this error: "Malformed [mappings] section for type [dynamic_templates], should include an inner object describing the mapping". I was able to replicate it in the Kibana dev tool if I explicitly pass in includeTypeName=true and omit the mapping type in my json.
   
   This addresses the issue depending on the version of Elasticsearch in
   use.
   
   Fixes #2559

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services