You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/16 18:16:50 UTC
[GitHub] zeppelin pull request #1905: [ZEPPELIN-1974] Remove extension from webpack c...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1905
[ZEPPELIN-1974] Remove extension from webpack config for visualization bundle
### What is this PR for?
webpack.config.js for creating visualization bundle has unnecessary extension configuration, which makes unable to import some libraries.
This PR removes the unnecessary configuration and propagate 'npm install' error message to front-end.
### What type of PR is it?
Bug Fix
### Todos
* [x] - exclude 'extensions' from webpack.config.js for visualization bundle
* [x] - propagate 'npm install' error to front-end
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1974
### Screenshots (if appropriate)
Before propagate error message to front-end
After propagate error message to front-end
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin npm_install_error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1905
----
commit 7635c55cd75f2c4b0fc251a131308fb79a1ecff0
Author: Lee moon soo <mo...@apache.org>
Date: 2017-01-16T18:03:23Z
Remove extension from webpack config for visualization bundle
commit b66558840661bac75e83a2c8d34f8d382391cdae
Author: Lee moon soo <mo...@apache.org>
Date: 2017-01-16T18:13:45Z
Propagate npm install error to front-end
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1905: [ZEPPELIN-1974] Remove extension from webpack config f...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1905
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1905: [ZEPPELIN-1974] Remove extension from webpack c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1905: [ZEPPELIN-1974] Remove extension from webpack config f...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1905
Thanks @1ambda for taking a look.
Merge to master if no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---