[GitHub] wido commented on a change in pull request #3000: Added two more device names (lo* and dummy*)

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #3000: Added two more device names (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r230693871
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -2149,7 +2152,7 @@ So if getMinSpeed() returns null we fall back to getSpeed().
         /* Add a VirtIO channel for SystemVMs for communication and provisioning */
         if (vmTO.getType() != VirtualMachine.Type.User) {
             devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", ChannelDef.ChannelType.UNIX,
-                              new File(_qemuSocketsPath + "/" + vmTO.getName() + ".agent")));
+                    new File(_qemuSocketsPath + "/" + vmTO.getName() + ".agent")));
 
 Review comment:
   While you are busy with this, why not use File.seperator?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services