You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/04 10:19:16 UTC
[GitHub] [james-project] jeantil opened a new pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
jeantil opened a new pull request #905:
URL: https://github.com/apache/james-project/pull/905
They can have been acknowledged and thus the underlying mime message removed from the store since we started browsing. We therefore ignore messages that can no longer be found in the mime message store. See jora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #905:
URL: https://github.com/apache/james-project/pull/905#issuecomment-1063654741
```
<p><span style="font-weight:bold">org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest.org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest</span></p><div style="text-align:right;">Failing for the past 1 build
(Since <a href="https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-905/11/" class="model-link"><span style="width: 16px; height: 16px; " class="build-status-icon__wrapper icon-red icon-sm"><span class="build-status-icon__outer"><svg viewBox="0 0 24 24" focusable="false" class="svg-icon "><use href="https://ci-builds.apache.org/images/build-status/build-status-sprite.svg#build-status-static"></use></svg></span><svg viewBox="0 0 24 24" focusable="false" class="svg-icon icon-red icon-sm"><use href="https://ci-builds.apache.org/static/40b37e2d/images/build-status/build-status-sprite.svg#last-failed"></use></svg></span>#11</a> )
</div><div style="text-align:right;"><a href="https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-905/11/testReport/junit/org.apache.james.mpt.smtp/CassandraPulsarForwardSmtpTest/org_apache_james_mpt_smtp_CassandraPulsarForwardSmtpTest/history">Took 1 ms.</a></div><div id="description"><div></div><div class="jenkins-buttons-row jenkins-buttons-row--invert"></div></div>
<h3>Error Message</h3><pre>Could not initialize class org.apache.james.backends.es.v7.DockerElasticSearchSingleton</pre><h3>Stacktrace</h3><pre>java.lang.NoClassDefFoundError: Could not initialize class org.apache.james.backends.es.v7.DockerElasticSearchSingleton
at org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest.<clinit>(CassandraPulsarForwardSmtpTest.java:37)
</pre>org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest.org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest
Failing for the past 1 build (Since [#11](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-905/11/) )
[Took 1 ms.](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-905/11/testReport/junit/org.apache.james.mpt.smtp/CassandraPulsarForwardSmtpTest/org_apache_james_mpt_smtp_CassandraPulsarForwardSmtpTest/history)
Error Message
Could not initialize class org.apache.james.backends.es.v7.DockerElasticSearchSingleton
Stacktrace
java.lang.NoClassDefFoundError: Could not initialize class org.apache.james.backends.es.v7.DockerElasticSearchSingleton
at org.apache.james.mpt.smtp.CassandraPulsarForwardSmtpTest.<clinit>(CassandraPulsarForwardSmtpTest.java:37)
```
I restarted the build.
BTW we might not need to start ElasticSearch at all for those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #905:
URL: https://github.com/apache/james-project/pull/905#discussion_r823100224
##########
File path: server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
##########
@@ -137,6 +137,23 @@ default void browseShouldReturnSingleElement() throws Exception {
.containsExactly("name");
}
+ @Test
+ default void browseShouldReturnEmptyWhenSingleDequeueMessage() throws Exception {
Review comment:
So I had a quick look at the actual stacktrace :
```
com.rabbitmq.client.AlreadyClosedException: channel is already closed due to clean channel shutdown; protocol method: #method<channel.close>(reply-code=200, reply-text=OK, class-id=0, method-id=0)
at com.rabbitmq.client.impl.AMQChannel.ensureIsOpen(AMQChannel.java:258)
at com.rabbitmq.client.impl.AMQChannel.transmit(AMQChannel.java:427)
at com.rabbitmq.client.impl.AMQChannel.transmit(AMQChannel.java:421)
at com.rabbitmq.client.impl.recovery.RecoveryAwareChannelN.basicAck(RecoveryAwareChannelN.java:93)
at com.rabbitmq.client.impl.recovery.AutorecoveringChannel.basicAck(AutorecoveringChannel.java:439)
at reactor.rabbitmq.AcknowledgableDelivery.basicAck(AcknowledgableDelivery.java:110)
at reactor.rabbitmq.AcknowledgableDelivery.ack(AcknowledgableDelivery.java:62)
... 16 common frames omitted
Wrapped by: reactor.rabbitmq.RabbitFluxException: Not retryable exception, cannot retry
at reactor.rabbitmq.ExceptionHandlers$SimpleRetryTemplate.retry(ExceptionHandlers.java:125)
at reactor.rabbitmq.ExceptionHandlers$RetryAcknowledgmentExceptionHandler.accept(ExceptionHandlers.java:143)
at reactor.rabbitmq.ExceptionHandlers$RetryAcknowledgmentExceptionHandler.accept(ExceptionHandlers.java:130)
at reactor.rabbitmq.AcknowledgableDelivery.retry(AcknowledgableDelivery.java:130)
at reactor.rabbitmq.AcknowledgableDelivery.ack(AcknowledgableDelivery.java:64)
at reactor.rabbitmq.AcknowledgableDelivery.ack(AcknowledgableDelivery.java:76)
at org.apache.james.queue.rabbitmq.Dequeuer.lambda$ack$4(Dequeuer.java:130)
at com.github.fge.lambdas.consumers.ThrowingConsumer.accept(ThrowingConsumer.java:22)
at org.apache.james.queue.rabbitmq.Dequeuer$RabbitMQMailQueueItem.done(Dequeuer.java:75)
at org.apache.james.queue.api.RawMailQueueItem.done(RawMailQueueItem.java:39)
at org.apache.james.queue.api.MailQueueContract.lambda$dequeueShouldBeConcurrent$7(MailQueueContract.java:581)
```
looking at other tests, it looks like
```
Flux.from(getManageableMailQueue().deQueue())
.doOnNext(Throwing.consumer(item -> item.done(true)))
.blockFirst();
```
works but
```
MailQueue.MailQueueItem mailQueueItem = Flux.from(getMailQueue().deQueue()).blockFirst();
mailQueueItem.done(true);
```
doesn't for the rabbitmq implementation. I find that surprising as nothing indicates a depency on some kind of context but I have aligned the test with the existing suite and it passes locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #905:
URL: https://github.com/apache/james-project/pull/905#issuecomment-1059045154
Sorry for the force push : I forgot to add the Co-Authored-By in the initial commit, there have been no other changes to the commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #905:
URL: https://github.com/apache/james-project/pull/905#discussion_r821511362
##########
File path: server/queue/queue-api/src/test/java/org/apache/james/queue/api/ManageableMailQueueContract.java
##########
@@ -137,6 +137,23 @@ default void browseShouldReturnSingleElement() throws Exception {
.containsExactly("name");
}
+ @Test
+ default void browseShouldReturnEmptyWhenSingleDequeueMessage() throws Exception {
Review comment:
This test seems to be failing for the RabbitMQMailqueue too.
Maybe we can ignore the "blob not found" issue there also?
@jeantil do you want to give this a shot?
CF https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-905/9/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #905:
URL: https://github.com/apache/james-project/pull/905#issuecomment-1063982554
@Arsnael thanks for the merge !
@chibenwa about
> BTW we might not need to start ElasticSearch at all for those tests.
I tried running the test class without it and locally it worked fine. Feel free to remove it, opening a PR to remove a single line feels a bit extreme :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #905: [JAMES-3721] Fixes ObjectNotFoundExceptions when browsing mails
Posted by GitBox <gi...@apache.org>.
Arsnael merged pull request #905:
URL: https://github.com/apache/james-project/pull/905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org