You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:03:40 UTC
[GitHub] [doris] cambyzju opened a new pull request, #13361: [fix](array-type) bugfix for array column with delete condition
cambyzju opened a new pull request, #13361:
URL: https://github.com/apache/doris/pull/13361
# Proposed changes
Issue Number: close #13360
## Problem summary
fix for SQL with array column:
`delete from tbl where c_array is null;`
more info please refer to https://github.com/apache/doris/issues/13360
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 merged pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
xy720 merged PR #13361:
URL: https://github.com/apache/doris/pull/13361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1279889529
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1285905585
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1279889524
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1284564434
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.02 seconds
load time: 579 seconds
storage size: 17154768600 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020045618_clickbench_pr_31546.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1285102379
> TeamCity pipeline, clickbench performance test result: the sum of best hot time: 40.02 seconds load time: 579 seconds storage size: 17154768600 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020045618_clickbench_pr_31546.html
,
It seems this pr should not make performance degradation, only add some logic for ARRAY case and use UNLIKELY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1285443908
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.51 seconds
load time: 586 seconds
storage size: 17154768693 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020201710_clickbench_pr_31932.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13361: [fix](array-type) bugfix for array column with delete condition
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13361:
URL: https://github.com/apache/doris/pull/13361#issuecomment-1279553130
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221015064013_clickbench_pr_29630.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org