[GitHub] [commons-imaging] kinow commented on a diff in pull request #280: Refactor BasicCParser::unescapeString()

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on code in PR #280:
URL: https://github.com/apache/commons-imaging/pull/280#discussion_r1112199944


##########
src/main/java/org/apache/commons/imaging/common/BasicCParser.java:
##########
@@ -417,4 +341,103 @@ public static void unescapeString(final StringBuilder stringBuilder, final Strin
                     + "unterminated escape sequence found in string");
         }
     }
+
+    private static int appendHex(int i, final StringBuilder stringBuilder, final String string)

Review Comment:
   Could you add some javadoc to these methods too, please, @snumlautoken ? The names are self-explanatory, but might still be helpful to be explicit about it, and also mention the use of the parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org