You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/03/28 13:23:30 UTC
[PR] [SPARK-47629] Add `common/variant` to maven daily test module list [spark]
LuciferYang opened a new pull request, #45754:
URL: https://github.com/apache/spark/pull/45754
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #45754: [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list
URL: https://github.com/apache/spark/pull/45754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #45754:
URL: https://github.com/apache/spark/pull/45754#discussion_r1543019218
##########
.github/workflows/build_and_test.yml:
##########
@@ -327,6 +327,11 @@ jobs:
${{ needs.precondition.outputs.image_url }}
# Use the infra image cache to speed up
cache-from: type=registry,ref=ghcr.io/apache/spark/apache-spark-github-action-image-cache:${{ inputs.branch }}
+ maven-test:
Review Comment:
will revert after test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #45754:
URL: https://github.com/apache/spark/pull/45754#issuecomment-2026556682
The `variant ` module does not have any test cases now. Let me revert the change of `build_and_test.yml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #45754:
URL: https://github.com/apache/spark/pull/45754#issuecomment-2026544445
```
2024-03-28T18:48:08.9171911Z 3 warnings.
2024-03-28T18:48:12.6489322Z Discovery starting.
2024-03-28T18:48:14.4086181Z Discovery completed in 1 second, 814 milliseconds.
2024-03-28T18:48:14.4182932Z Run starting. Expected test count is: 35
2024-03-28T18:48:14.4248382Z KinesisInputDStreamBuilderSuite:
2024-03-28T18:48:14.4712987Z - should raise an exception if the StreamingContext is missing
2024-03-28T18:48:14.4756297Z - should raise an exception if the stream name is missing
2024-03-28T18:48:14.4758553Z - should raise an exception if the checkpoint app name is missing
2024-03-28T18:48:14.6237137Z - should propagate required values to KinesisInputDStream
2024-03-28T18:48:14.6309982Z - should propagate default values to KinesisInputDStream
2024-03-28T18:48:14.8843092Z OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
2024-03-28T18:48:15.4918194Z - should propagate custom non-auth values to KinesisInputDStream
2024-03-28T18:48:15.4980613Z - old Api should throw UnsupportedOperationExceptionexception with AT_TIMESTAMP
2024-03-28T18:48:15.7380623Z WithoutAggregationKinesisBackedBlockRDDSuite:
2024-03-28T18:48:15.7397598Z - Basic reading from Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7401340Z - Read data available in both block manager and Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7404229Z - Read data available only in block manager, not in Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7407274Z - Read data available only in Kinesis, not in block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7411087Z - Read data available partially in block manager, rest in Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7413957Z - Test isBlockValid skips block fetching from block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.7416964Z - Test whether RDD is valid after removing blocks from block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:15.8027369Z KinesisReceiverSuite:
2024-03-28T18:48:16.0598578Z - process records including store and set checkpointer
2024-03-28T18:48:16.0699421Z - split into multiple processes if a limitation is set
2024-03-28T18:48:16.0819317Z - shouldn't store and update checkpointer when receiver is stopped
2024-03-28T18:48:16.0934673Z - shouldn't update checkpointer when exception occurs during store
2024-03-28T18:48:16.1025986Z - shutdown should checkpoint if the reason is TERMINATE
2024-03-28T18:48:16.1071125Z - shutdown should not checkpoint if the reason is something other than TERMINATE
2024-03-28T18:48:16.1126724Z - retry success on first attempt
2024-03-28T18:48:16.1197799Z - retry success on second attempt after a Kinesis throttling exception
2024-03-28T18:48:16.1800756Z - retry success on second attempt after a Kinesis dependency exception
2024-03-28T18:48:16.1858656Z - retry failed after a shutdown exception
2024-03-28T18:48:16.1921030Z - retry failed after an invalid state exception
2024-03-28T18:48:16.1961305Z - retry failed after unexpected exception
2024-03-28T18:48:16.3093821Z - retry failed after exhausting all retries
2024-03-28T18:48:16.4074362Z WithAggregationKinesisBackedBlockRDDSuite:
2024-03-28T18:48:16.4079349Z - Basic reading from Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4083548Z - Read data available in both block manager and Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4087178Z - Read data available only in block manager, not in Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4090667Z - Read data available only in Kinesis, not in block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4094266Z - Read data available partially in block manager, rest in Kinesis [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4097683Z - Test isBlockValid skips block fetching from block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4101297Z - Test whether RDD is valid after removing blocks from block manager [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.4733873Z WithAggregationKinesisStreamSuite:
2024-03-28T18:48:16.5597475Z - RDD generation
2024-03-28T18:48:16.6061947Z - basic operation [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.6064494Z - custom message handling [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.7100481Z - Kinesis read with custom configurations
2024-03-28T18:48:16.7333239Z - split and merge shards in a stream [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.7334445Z - failure recovery [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.7335501Z - Prepare KinesisTestUtils [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:16.7821666Z KinesisCheckpointerSuite:
2024-03-28T18:48:16.7831058Z - checkpoint is not called twice for the same sequence number
2024-03-28T18:48:16.7838199Z - checkpoint is called after sequence number increases
2024-03-28T18:48:16.8023248Z - should checkpoint if we have exceeded the checkpoint interval
2024-03-28T18:48:16.8063902Z - shouldn't checkpoint if we have not exceeded the checkpoint interval
2024-03-28T18:48:16.8140028Z - should not checkpoint for the same sequence number
2024-03-28T18:48:16.8179612Z - removing checkpointer checkpoints one last time
2024-03-28T18:48:16.8907449Z - if checkpointing is going on, wait until finished before removing and checkpointing
2024-03-28T18:48:16.9456192Z SparkAWSCredentialsBuilderSuite:
2024-03-28T18:48:16.9457552Z - should build DefaultCredentials when given no params
2024-03-28T18:48:16.9458711Z - should build BasicCredentials
2024-03-28T18:48:16.9461090Z - should build STSCredentials
2024-03-28T18:48:16.9470237Z - SparkAWSCredentials classes should be serializable
2024-03-28T18:48:16.9978309Z WithoutAggregationKinesisStreamSuite:
2024-03-28T18:48:17.0384093Z - RDD generation
2024-03-28T18:48:17.0716143Z - basic operation [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:17.0718145Z - custom message handling [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:17.1532701Z - Kinesis read with custom configurations
2024-03-28T18:48:17.1870008Z - split and merge shards in a stream [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:17.1876655Z - failure recovery [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:17.1879241Z - Prepare KinesisTestUtils [enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
2024-03-28T18:48:17.2167546Z Run completed in 4 seconds, 599 milliseconds.
2024-03-28T18:48:17.2168692Z Total number of tests run: 35
2024-03-28T18:48:17.2169621Z Suites: completed 9, aborted 0
2024-03-28T18:48:17.2170604Z Tests: succeeded 35, failed 0, canceled 0, ignored 24, pending 0
2024-03-28T18:48:17.2171403Z All tests passed.
```
https://github.com/LuciferYang/spark/actions/runs/8468321679/job/23201055867
kinesisI-asl already passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47629][INFRA] Add `common/variant` and `connector/kinesis-asl` to maven daily test module list [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #45754:
URL: https://github.com/apache/spark/pull/45754#issuecomment-2026678488
Maven test passed. Merged into master for Apache Spark 4.0. I will monitor GA ~
Thanks @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org