You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/07 06:17:08 UTC
[bookkeeper] branch master updated: [CI] Allow selecting a list of
precommit checks to skip in the pull request description.
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 2b66cb1 [CI] Allow selecting a list of precommit checks to skip in the pull request description.
2b66cb1 is described below
commit 2b66cb16d6f6a16c556ac304d3337a74f99a95df
Author: Sijie Guo <si...@apache.org>
AuthorDate: Wed Jun 6 23:17:00 2018 -0700
[CI] Allow selecting a list of precommit checks to skip in the pull request description.
Descriptions of the changes in this PR:
*Motivation*
precommit checks are good. however sometime it takes a long time to wait for precommit checks to complete,
for trivial changes (e.g. documentation, ci jenkins files, scripts, proposals).
*Changes*
This PR updates the PULL_REQUEST_TEMPLATE.md to provide a list of precommit checks to be allowed to skip.
So people can choose skip some precommit checks when filing a pull request.
Author: Sijie Guo <si...@apache.org>
Reviewers: Enrico Olivelli <eo...@gmail.com>, Jia Zhai <None>
This closes #1494 from sijie/skip_tests_is_too_general
---
.github/PULL_REQUEST_TEMPLATE.md | 27 +++++++++++++++++++++-
.../job_bookkeeper_precommit_bookie_tests.groovy | 4 ++--
.../job_bookkeeper_precommit_client_tests.groovy | 4 ++--
...ob_bookkeeper_precommit_integrationtests.groovy | 2 +-
.../jenkins/job_bookkeeper_precommit_java8.groovy | 4 ++--
.../jenkins/job_bookkeeper_precommit_java9.groovy | 4 ++--
...job_bookkeeper_precommit_remaining_tests.groovy | 4 ++--
...b_bookkeeper_precommit_replication_tests.groovy | 4 ++--
.../job_bookkeeper_precommit_tls_tests.groovy | 4 ++--
9 files changed, 41 insertions(+), 16 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index b9558fa..064f988 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,10 +1,35 @@
Descriptions of the changes in this PR:
-(PR description content here)...
+
+
+### Motivation
+
+(Explain: why you're making that change, what is the problem you're trying to solve)
+
+### Changes
+
+(Describe: what changes you have made)
Master Issue: #<master-issue-number>
> ---
+> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
+> checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
+> the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
+> can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
+> you are not sure, committers will help you:
+>
+> - [ ] [skip bookkeeper-server bookie tests]: skip testing `org.apache.bookkeeper.bookie` in bookkeeper-server module.
+> - [ ] [skip bookkeeper-server client tests]: skip testing `org.apache.bookkeeper.client` in bookkeeper-server module.
+> - [ ] [skip bookkeeper-server replication tests]: skip testing `org.apache.bookkeeper.replication` in bookkeeper-server module.
+> - [ ] [skip bookkeeper-server tls tests]: skip testing `org.apache.bookkeeper.tls` in bookkeeper-server module.
+> - [ ] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
+> - [ ] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
+> - [ ] [skip build java8]: skip build on java8. *ONLY* skip this when *ONLY* changing files under documentation under `site`.
+> - [ ] [skip build java9]: skip build on java9. *ONLY* skip this when *ONLY* changing files under documentation under `site`.
+> ---
+
+> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_bookie_tests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_bookie_tests.groovy
index c5543eb..137abdd 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_bookie_tests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_bookie_tests.groovy
@@ -38,8 +38,8 @@ freeStyleJob('bookkeeper_precommit_bookie_tests') {
common_job_properties.setPreCommit(
delegate,
'Bookie Tests',
- '.*(re)?run (bookie )?tests.*',
- '.*\\[skip (bookie )?tests\\].*',
+ '.*(re)?run bookkeeper-server (bookie )?tests.*',
+ '.*\\[x\\] \\[skip bookkeeper-server (bookie )?tests\\].*',
true)
steps {
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_client_tests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_client_tests.groovy
index dd72c93..28cfba0 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_client_tests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_client_tests.groovy
@@ -38,8 +38,8 @@ freeStyleJob('bookkeeper_precommit_client_tests') {
common_job_properties.setPreCommit(
delegate,
'Client Tests',
- '.*(re)?run (client )?tests.*',
- '.*\\[skip (client )?tests\\].*',
+ '.*(re)?run bookkeeper-server (client )?tests.*',
+ '.*\\[x\\] \\[skip bookkeeper-server (client )?tests\\].*',
true)
steps {
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_integrationtests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_integrationtests.groovy
index 61e9a02..ac56b9e 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_integrationtests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_integrationtests.groovy
@@ -41,7 +41,7 @@ freeStyleJob('bookkeeper_precommit_integrationtests') {
delegate,
'Integration Tests',
'.*(re)?run integration tests.*',
- '.*\\[skip integration tests\\].*')
+ '.*\\[x\\] \\[skip integration tests\\].*')
steps {
// Temporary information gathering to see if full disks are causing the builds to flake
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_java8.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_java8.groovy
index 48adf34..1e4615e 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_java8.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_java8.groovy
@@ -47,8 +47,8 @@ mavenJob('bookkeeper_precommit_pullrequest_java8') {
common_job_properties.setPreCommit(
delegate,
'Build (Java 8)',
- '.*(re)?build java8?.*',
- '.*\\[skip build java8?\\].*')
+ '.*(re)?build java8.*',
+ '.*\\[x\\] \\[skip build java8\\].*')
// Set Maven parameters.
common_job_properties.setMavenConfig(delegate)
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_java9.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_java9.groovy
index c4d65e3..399d915 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_java9.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_java9.groovy
@@ -47,8 +47,8 @@ mavenJob('bookkeeper_precommit_pullrequest_java9') {
common_job_properties.setPreCommit(
delegate,
'Build (Java 9)',
- '.*(re)?build java9?.*',
- '.*\\[skip build java9?\\].*')
+ '.*(re)?build java9.*',
+ '.*\\[x\\] \\[skip build java9\\].*')
// Set Maven parameters.
common_job_properties.setMavenConfig(delegate)
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_remaining_tests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_remaining_tests.groovy
index f0cbbd0..7449cb5 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_remaining_tests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_remaining_tests.groovy
@@ -42,8 +42,8 @@ freeStyleJob('bookkeeper_precommit_remaining_tests') {
common_job_properties.setPreCommit(
delegate,
'All Other Tests',
- '.*(re)?run (remaining )?tests.*',
- '.*\\[skip (remaining )?tests\\].*',
+ '.*(re)?run bookkeeper-server (remaining )?tests.*',
+ '.*\\[x\\] \\[skip bookkeeper-server (remaining )?tests\\].*',
true)
steps {
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_replication_tests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_replication_tests.groovy
index 46e79f9..70c6a69 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_replication_tests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_replication_tests.groovy
@@ -38,8 +38,8 @@ freeStyleJob('bookkeeper_precommit_replication_tests') {
common_job_properties.setPreCommit(
delegate,
'Replication Tests',
- '.*(re)?run (replication )?tests.*',
- '.*\\[skip (replication )?tests\\].*',
+ '.*(re)?run bookkeeper-server (replication )?tests.*',
+ '.*\\[x\\] \\[skip bookkeeper-server (replication )?tests\\].*',
true)
steps {
diff --git a/.test-infra/jenkins/job_bookkeeper_precommit_tls_tests.groovy b/.test-infra/jenkins/job_bookkeeper_precommit_tls_tests.groovy
index df9092d..0ffa177 100644
--- a/.test-infra/jenkins/job_bookkeeper_precommit_tls_tests.groovy
+++ b/.test-infra/jenkins/job_bookkeeper_precommit_tls_tests.groovy
@@ -38,8 +38,8 @@ freeStyleJob('bookkeeper_precommit_tls_tests') {
common_job_properties.setPreCommit(
delegate,
'TLS Tests',
- '.*(re)?run (tls )?tests.*',
- '.*\\[skip (tls )?tests\\].*',
+ '.*(re)?run bookkeeper-server (tls )?tests.*',
+ '.*\\[x\\] \\[skip bookkeeper-server (tls )?tests\\].*',
true)
steps {
--
To stop receiving notification emails like this one, please contact
sijie@apache.org.