You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Deepti Sehrawat (Code Review)" <ge...@cloudera.org> on 2021/10/27 00:45:51 UTC
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Deepti Sehrawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17981
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
IMPALA 10954: Make create, drop methods of kudu catalog service public
External frontend needs access to some private methods of kudu catalog
service. Hence, they are made public here to add support for CREATE and
DROP tables for Kudu from external frontend.
Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/17981/1
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 1
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has removed a vote on this change.
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9672/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 1
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 01:08:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17981/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17981/3//COMMIT_MSG@7
PS3, Line 7: IMPALA 10954
IMPALA-10954
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 3
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Nov 2021 14:50:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Deepti Sehrawat (Code Review)" <ge...@cloudera.org>.
Deepti Sehrawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
IMPALA-10954: Make create, drop methods of kudu catalog service public
External frontend needs access to some private methods of kudu catalog
service. Hence, they are made public here to add support for CREATE and
DROP tables for Kudu from external frontend.
Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/17981/4
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 4
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17981/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/17981/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@77
PS1, Line 77: public static void createSynchronizedTable(org.apache.hadoop.hive.metastore.api.Table msTbl,
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 1
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 00:46:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 5: Verified+1
The 2 Hbase test failures are due to flaky tests described in IMPALA-9161.
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 19:43:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9823/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 4
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Nov 2021 02:30:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9791/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 3
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Nov 2021 08:00:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA 10954: Make create, drop methods of kudu catalog service public
Posted by "Deepti Sehrawat (Code Review)" <ge...@cloudera.org>.
Deepti Sehrawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA 10954: Make create, drop methods of kudu catalog service public
......................................................................
IMPALA 10954: Make create, drop methods of kudu catalog service public
External frontend needs access to some private methods of kudu catalog
service. Hence, they are made public here to add support for CREATE and
DROP tables for Kudu from external frontend.
Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/17981/3
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 3
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 4
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Nov 2021 19:43:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
IMPALA-10954: Make create, drop methods of kudu catalog service public
External frontend needs access to some private methods of kudu catalog
service. Hence, they are made public here to add support for CREATE and
DROP tables for Kudu from external frontend.
Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Reviewed-on: http://gerrit.cloudera.org:8080/17981
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Aman Sinha <am...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Aman Sinha: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 6
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 19:44:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 01:56:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7670/
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 08:18:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7670/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 5
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 01:56:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10954: Make create, drop methods of kudu catalog service public
Posted by "Deepti Sehrawat (Code Review)" <ge...@cloudera.org>.
Deepti Sehrawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17981 )
Change subject: IMPALA-10954: Make create, drop methods of kudu catalog service public
......................................................................
Patch Set 4:
(1 comment)
Fixed commit message
http://gerrit.cloudera.org:8080/#/c/17981/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17981/3//COMMIT_MSG@7
PS3, Line 7: IMPALA-10954
> IMPALA-10954
Done
--
To view, visit http://gerrit.cloudera.org:8080/17981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
Gerrit-Change-Number: 17981
Gerrit-PatchSet: 4
Gerrit-Owner: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Deepti Sehrawat <sd...@gmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Nov 2021 02:09:30 +0000
Gerrit-HasComments: Yes