You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2013/03/20 19:39:15 UTC
[jira] [Comment Edited] (LUCENE-4848) Fix Directory implementations
to use NIO2 APIs
[ https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607969#comment-13607969 ]
Uwe Schindler edited comment on LUCENE-4848 at 3/20/13 6:38 PM:
----------------------------------------------------------------
Your patch again introduces code I already removed (the channel based indexoutput was removed, too, also the useess abstract base class)! Have you looked at my patch and used it as basis? If we want a channel based-IndexOutput then it has nothing to do with the base class, should be in e.g. NIOFSIndexOutput. This is also a separate issue.
I will now upload a patch again! When you make further changes, please *always* use the latest oatch with a clean checkout!
was (Author: thetaphi):
Your patch again introduces code I already removed (the channel based indexoutput was removed, too, also the useess abstract base class)! Have you looked at my patch and used it as basis? I we want a channel based-IndexOutput then it has nothing to do with the base class, should be in e.g. NIOFSIndexOutput. This is also a separate issue.
I will now upload a patch again! When you make further changes, please *always* use the latest oatch with a clean checkout!
> Fix Directory implementations to use NIO2 APIs
> ----------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch.txt
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any changes requested. I've included some minimal smoke tests, but any help in how to use the normal Lucene tests to perform more thorough testing would be appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org