You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/05/17 21:50:26 UTC
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated May 17, 2015, 7:50 p.m.)
Review request for mesos and Cody Maloney.
Summary (updated)
-----------------
Replaced os::dirname and os::basename with Path::dirname and Path::basename.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/execute.cpp dbd19e6
src/cli/mesos.cpp 171a707
src/cli/resolve.cpp a99b609
src/examples/load_generator_framework.cpp be1a3bf
src/examples/low_level_scheduler_libprocess.cpp bee2e7e
src/examples/low_level_scheduler_pthread.cpp fb8cd66
src/examples/persistent_volume_framework.cpp 8a893fc
src/examples/test_framework.cpp 9f4b53e
src/files/files.cpp ce02411
src/health-check/main.cpp a4ce742
src/launcher/executor.cpp de6f1b1
src/launcher/fetcher.cpp 796526f
src/local/main.cpp a641b9e
src/logging/logging.cpp 6b14575
src/master/main.cpp d5666bc
src/slave/main.cpp f762f5b
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.hpp b4d91b2
src/tests/fetcher_tests.cpp 4549e6a
src/tests/main.cpp e3fff5d
src/usage/main.cpp 97f55e9
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84507
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On May 18, 2015, 12:42 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:42 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp dbd19e6
> src/cli/mesos.cpp 171a707
> src/cli/resolve.cpp a99b609
> src/examples/load_generator_framework.cpp be1a3bf
> src/examples/low_level_scheduler_libprocess.cpp bee2e7e
> src/examples/low_level_scheduler_pthread.cpp fb8cd66
> src/examples/persistent_volume_framework.cpp 8a893fc
> src/examples/test_framework.cpp 9f4b53e
> src/files/files.cpp ce02411
> src/health-check/main.cpp a4ce742
> src/launcher/executor.cpp de6f1b1
> src/launcher/fetcher.cpp 796526f
> src/linux/cgroups.cpp df3211a
> src/local/main.cpp a641b9e
> src/logging/logging.cpp 6b14575
> src/master/main.cpp d5666bc
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
> src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
> src/slave/containerizer/linux_launcher.cpp b9e22e3
> src/slave/main.cpp f762f5b
> src/slave/state.hpp fed4b7e
> src/slave/state.cpp 8eda22a
> src/slave/status_update_manager.hpp b4d91b2
> src/tests/fetcher_tests.cpp 4549e6a
> src/tests/main.cpp e3fff5d
> src/tests/mesos.cpp 1d5639c
> src/usage/main.cpp 97f55e9
> src/zookeeper/group.cpp 173caa8
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
> On May 19, 2015, 8:13 p.m., Vinod Kone wrote:
> > src/cli/mesos.cpp, line 31
> > <https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31>
> >
> > So basename can never return an error? When did ::basename() return NULL?
>
> Alexander Rojas wrote:
> I checked in the `::basename` docs (`man 3 basename`) and the linux version doesn't seem to return any error ever and the osx version returns `NULL` and sets `errno = ENAMETOOLONG` if the length of the parameter is larger than `MAXPATHLEN`.
Thanks Alexander for jumping in - and yes indeed, the Posix as well as the GNU version never seem to return NULL on linux (see http://linux.die.net/man/3/basename). Can we drop this?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------
On May 17, 2015, 10:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 10:42 p.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp dbd19e6
> src/cli/mesos.cpp 171a707
> src/cli/resolve.cpp a99b609
> src/examples/load_generator_framework.cpp be1a3bf
> src/examples/low_level_scheduler_libprocess.cpp bee2e7e
> src/examples/low_level_scheduler_pthread.cpp fb8cd66
> src/examples/persistent_volume_framework.cpp 8a893fc
> src/examples/test_framework.cpp 9f4b53e
> src/files/files.cpp ce02411
> src/health-check/main.cpp a4ce742
> src/launcher/executor.cpp de6f1b1
> src/launcher/fetcher.cpp 796526f
> src/linux/cgroups.cpp df3211a
> src/local/main.cpp a641b9e
> src/logging/logging.cpp 6b14575
> src/master/main.cpp d5666bc
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
> src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
> src/slave/containerizer/linux_launcher.cpp b9e22e3
> src/slave/main.cpp f762f5b
> src/slave/state.hpp fed4b7e
> src/slave/state.cpp 8eda22a
> src/slave/status_update_manager.hpp b4d91b2
> src/tests/fetcher_tests.cpp 4549e6a
> src/tests/main.cpp e3fff5d
> src/tests/mesos.cpp 1d5639c
> src/usage/main.cpp 97f55e9
> src/zookeeper/group.cpp 173caa8
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On May 19, 2015, 10:13 p.m., Vinod Kone wrote:
> > src/cli/mesos.cpp, line 31
> > <https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31>
> >
> > So basename can never return an error? When did ::basename() return NULL?
I checked in the `::basename` docs (`man 3 basename`) and the linux version doesn't seem to return any error ever and the osx version returns `NULL` and sets `errno = ENAMETOOLONG` if the length of the parameter is larger than `MAXPATHLEN`.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------
On May 18, 2015, 12:42 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:42 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp dbd19e6
> src/cli/mesos.cpp 171a707
> src/cli/resolve.cpp a99b609
> src/examples/load_generator_framework.cpp be1a3bf
> src/examples/low_level_scheduler_libprocess.cpp bee2e7e
> src/examples/low_level_scheduler_pthread.cpp fb8cd66
> src/examples/persistent_volume_framework.cpp 8a893fc
> src/examples/test_framework.cpp 9f4b53e
> src/files/files.cpp ce02411
> src/health-check/main.cpp a4ce742
> src/launcher/executor.cpp de6f1b1
> src/launcher/fetcher.cpp 796526f
> src/linux/cgroups.cpp df3211a
> src/local/main.cpp a641b9e
> src/logging/logging.cpp 6b14575
> src/master/main.cpp d5666bc
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
> src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
> src/slave/containerizer/linux_launcher.cpp b9e22e3
> src/slave/main.cpp f762f5b
> src/slave/state.hpp fed4b7e
> src/slave/state.cpp 8eda22a
> src/slave/status_update_manager.hpp b4d91b2
> src/tests/fetcher_tests.cpp 4549e6a
> src/tests/main.cpp e3fff5d
> src/tests/mesos.cpp 1d5639c
> src/usage/main.cpp 97f55e9
> src/zookeeper/group.cpp 173caa8
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 19, 2015, 8:13 p.m., Vinod Kone wrote:
> > src/cli/mesos.cpp, line 31
> > <https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31>
> >
> > So basename can never return an error? When did ::basename() return NULL?
>
> Alexander Rojas wrote:
> I checked in the `::basename` docs (`man 3 basename`) and the linux version doesn't seem to return any error ever and the osx version returns `NULL` and sets `errno = ENAMETOOLONG` if the length of the parameter is larger than `MAXPATHLEN`.
>
> Till Toenshoff wrote:
> Thanks Alexander for jumping in - and yes indeed, the Posix as well as the GNU version never seem to return NULL on linux (see http://linux.die.net/man/3/basename). Can we drop this?
SGTM.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------
On June 5, 2015, 1:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 1:26 p.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 1121e19
> src/cli/resolve.cpp 74545a0
> src/examples/low_level_scheduler_libprocess.cpp df92e8d
> src/examples/low_level_scheduler_pthread.cpp 175ee4d
> src/examples/persistent_volume_framework.cpp ee2311f
> src/examples/test_framework.cpp 25f5f8c
> src/files/files.cpp ce02411
> src/health-check/main.cpp 3607479
> src/launcher/executor.cpp f79dc60
> src/linux/cgroups.cpp 831237b
> src/local/main.cpp ec21ed0
> src/logging/logging.cpp 6b14575
> src/slave/containerizer/fetcher.cpp f77652b
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd3525
> src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153f
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf
> src/slave/containerizer/linux_launcher.cpp 8eae258
> src/slave/main.cpp c4d8940
> src/slave/state.hpp fed4b7e
> src/slave/state.cpp 8eda22a
> src/slave/status_update_manager.cpp 1d7c4d0
> src/tests/fetcher_tests.cpp 361d918
> src/tests/mesos.cpp d3a8bb7
> src/zookeeper/group.cpp 173caa8
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------
src/cli/mesos.cpp
<https://reviews.apache.org/r/34260/#comment135600>
So basename can never return an error? When did ::basename() return NULL?
- Vinod Kone
On May 17, 2015, 10:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 10:42 p.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp dbd19e6
> src/cli/mesos.cpp 171a707
> src/cli/resolve.cpp a99b609
> src/examples/load_generator_framework.cpp be1a3bf
> src/examples/low_level_scheduler_libprocess.cpp bee2e7e
> src/examples/low_level_scheduler_pthread.cpp fb8cd66
> src/examples/persistent_volume_framework.cpp 8a893fc
> src/examples/test_framework.cpp 9f4b53e
> src/files/files.cpp ce02411
> src/health-check/main.cpp a4ce742
> src/launcher/executor.cpp de6f1b1
> src/launcher/fetcher.cpp 796526f
> src/linux/cgroups.cpp df3211a
> src/local/main.cpp a641b9e
> src/logging/logging.cpp 6b14575
> src/master/main.cpp d5666bc
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
> src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
> src/slave/containerizer/linux_launcher.cpp b9e22e3
> src/slave/main.cpp f762f5b
> src/slave/state.hpp fed4b7e
> src/slave/state.cpp 8eda22a
> src/slave/status_update_manager.hpp b4d91b2
> src/tests/fetcher_tests.cpp 4549e6a
> src/tests/main.cpp e3fff5d
> src/tests/mesos.cpp 1d5639c
> src/usage/main.cpp 97f55e9
> src/zookeeper/group.cpp 173caa8
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated June 24, 2015, 2:46 a.m.)
Review request for mesos and Cody Maloney.
Changes
-------
Addressed comments.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8
src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f
src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e
src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834
src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb
src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566
src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da
src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e
src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
src/slave/containerizer/isolators/network/port_mapping.cpp f8018f292b8ca96c1ad5e535d72f18bb4dbfe330
src/slave/containerizer/linux_launcher.cpp 7b24db8b9d08d61ecae25facf30823c6eaf5b03a
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159
src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14
src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/slave/main.cpp, line 32
> > <https://reviews.apache.org/r/34260/diff/9/?file=990340#file990340line32>
> >
> > Why do we need this header here? There is no other change in the file.
hah, thanks - forgot to remove that during some of the updates.
> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/slave/state.hpp, lines 133-134
> > <https://reviews.apache.org/r/34260/diff/9/?file=990341#file990341line133>
> >
> > I think this will fit on one line :-).
Aye, fixed.
> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/logging/logging.cpp, line 234
> > <https://reviews.apache.org/r/34260/diff/9/?file=990333#file990333line234>
> >
> > May be replace basename here with 'Path(argv0).basename()'?
True - I also removed the `suffix` instance.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review88985
-----------------------------------------------------------
On June 24, 2015, 2:46 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 2:46 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8
> src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
> src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e
> src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
> src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834
> src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb
> src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
> src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566
> src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da
> src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
> src/slave/containerizer/isolators/network/port_mapping.cpp f8018f292b8ca96c1ad5e535d72f18bb4dbfe330
> src/slave/containerizer/linux_launcher.cpp 7b24db8b9d08d61ecae25facf30823c6eaf5b03a
> src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
> src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
> src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159
> src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
> src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14
> src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review88985
-----------------------------------------------------------
Ship it!
LGTM minus some minor comments. Feel free to ignore/drop if they are beyond the scope of this RR :).
src/logging/logging.cpp (line 229)
<https://reviews.apache.org/r/34260/#comment141578>
May be replace basename here with 'Path(argv0).basename()'?
src/slave/main.cpp (line 32)
<https://reviews.apache.org/r/34260/#comment141579>
Why do we need this header here? There is no other change in the file.
src/slave/state.hpp (lines 130 - 131)
<https://reviews.apache.org/r/34260/#comment141580>
I think this will fit on one line :-).
- Kapil Arya
On June 23, 2015, 4:26 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 4:26 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8
> src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
> src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e
> src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
> src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834
> src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb
> src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
> src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566
> src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da
> src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
> src/slave/containerizer/isolators/network/port_mapping.cpp 1eb8173b0618f7461aa29b1df1ccaf1c2be5f8f6
> src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
> src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
> src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
> src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159
> src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
> src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14
> src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review89000
-----------------------------------------------------------
Ship it!
LGTM. Modulo missing headers and Kapil's comments.
src/examples/balloon_framework.cpp (line 34)
<https://reviews.apache.org/r/34260/#comment141597>
include path header?
src/examples/long_lived_framework.cpp (line 31)
<https://reviews.apache.org/r/34260/#comment141595>
include path header?
src/examples/low_level_scheduler_libprocess.cpp (line 46)
<https://reviews.apache.org/r/34260/#comment141594>
include path header?
src/slave/containerizer/isolators/cgroups/cpushare.cpp (line 40)
<https://reviews.apache.org/r/34260/#comment141601>
include path header?
src/slave/containerizer/isolators/cgroups/mem.cpp (line 40)
<https://reviews.apache.org/r/34260/#comment141600>
include path header?
src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 46)
<https://reviews.apache.org/r/34260/#comment141599>
include path header?
src/slave/containerizer/isolators/network/port_mapping.cpp (line 47)
<https://reviews.apache.org/r/34260/#comment141598>
include path header?
- Vinod Kone
On June 23, 2015, 8:26 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:26 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8
> src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
> src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e
> src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
> src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834
> src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb
> src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
> src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566
> src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da
> src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
> src/slave/containerizer/isolators/network/port_mapping.cpp 1eb8173b0618f7461aa29b1df1ccaf1c2be5f8f6
> src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
> src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
> src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
> src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159
> src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
> src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14
> src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068
>
> Diff: https://reviews.apache.org/r/34260/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
Changes
-------
Rebased.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8
src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f
src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e
src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834
src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb
src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566
src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da
src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e
src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
src/slave/containerizer/isolators/network/port_mapping.cpp 1eb8173b0618f7461aa29b1df1ccaf1c2be5f8f6
src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025
src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159
src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14
src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated June 9, 2015, midnight)
Review request for mesos and Cody Maloney.
Changes
-------
Rebased.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos.cpp bb92b68e
src/cli/resolve.cpp 74545a0
src/examples/low_level_scheduler_libprocess.cpp fe4eb29
src/examples/low_level_scheduler_pthread.cpp 1d285d8
src/examples/persistent_volume_framework.cpp ee2311f
src/examples/test_framework.cpp 99b981d
src/files/files.cpp 3cdd38a
src/health-check/main.cpp 3607479
src/launcher/executor.cpp 9a3a1c3
src/linux/cgroups.cpp 831237b
src/local/main.cpp ec21ed0
src/logging/logging.cpp 6b14575
src/slave/containerizer/fetcher.cpp f77652b
src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd3525
src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79
src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153f
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4
src/slave/containerizer/linux_launcher.cpp 8eae258
src/slave/main.cpp c379243
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.cpp 1d7c4d0
src/tests/fetcher_tests.cpp 361d918
src/tests/mesos.cpp dff45b0
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated June 5, 2015, 1:26 p.m.)
Review request for mesos and Cody Maloney.
Changes
-------
Rebased.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos.cpp 1121e19
src/cli/resolve.cpp 74545a0
src/examples/low_level_scheduler_libprocess.cpp df92e8d
src/examples/low_level_scheduler_pthread.cpp 175ee4d
src/examples/persistent_volume_framework.cpp ee2311f
src/examples/test_framework.cpp 25f5f8c
src/files/files.cpp ce02411
src/health-check/main.cpp 3607479
src/launcher/executor.cpp f79dc60
src/linux/cgroups.cpp 831237b
src/local/main.cpp ec21ed0
src/logging/logging.cpp 6b14575
src/slave/containerizer/fetcher.cpp f77652b
src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd3525
src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79
src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153f
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf
src/slave/containerizer/linux_launcher.cpp 8eae258
src/slave/main.cpp c4d8940
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.cpp 1d7c4d0
src/tests/fetcher_tests.cpp 361d918
src/tests/mesos.cpp d3a8bb7
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated May 17, 2015, 10:42 p.m.)
Review request for mesos and Cody Maloney.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/execute.cpp dbd19e6
src/cli/mesos.cpp 171a707
src/cli/resolve.cpp a99b609
src/examples/load_generator_framework.cpp be1a3bf
src/examples/low_level_scheduler_libprocess.cpp bee2e7e
src/examples/low_level_scheduler_pthread.cpp fb8cd66
src/examples/persistent_volume_framework.cpp 8a893fc
src/examples/test_framework.cpp 9f4b53e
src/files/files.cpp ce02411
src/health-check/main.cpp a4ce742
src/launcher/executor.cpp de6f1b1
src/launcher/fetcher.cpp 796526f
src/linux/cgroups.cpp df3211a
src/local/main.cpp a641b9e
src/logging/logging.cpp 6b14575
src/master/main.cpp d5666bc
src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
src/slave/containerizer/linux_launcher.cpp b9e22e3
src/slave/main.cpp f762f5b
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.hpp b4d91b2
src/tests/fetcher_tests.cpp 4549e6a
src/tests/main.cpp e3fff5d
src/tests/mesos.cpp 1d5639c
src/usage/main.cpp 97f55e9
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated May 17, 2015, 10:31 p.m.)
Review request for mesos and Cody Maloney.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/execute.cpp dbd19e6
src/cli/mesos.cpp 171a707
src/cli/resolve.cpp a99b609
src/examples/load_generator_framework.cpp be1a3bf
src/examples/low_level_scheduler_libprocess.cpp bee2e7e
src/examples/low_level_scheduler_pthread.cpp fb8cd66
src/examples/persistent_volume_framework.cpp 8a893fc
src/examples/test_framework.cpp 9f4b53e
src/files/files.cpp ce02411
src/health-check/main.cpp a4ce742
src/launcher/executor.cpp de6f1b1
src/launcher/fetcher.cpp 796526f
src/linux/cgroups.cpp df3211a
src/local/main.cpp a641b9e
src/logging/logging.cpp 6b14575
src/master/main.cpp d5666bc
src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
src/slave/containerizer/linux_launcher.cpp b9e22e3
src/slave/main.cpp f762f5b
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.hpp b4d91b2
src/tests/fetcher_tests.cpp 4549e6a
src/tests/main.cpp e3fff5d
src/tests/mesos.cpp 1d5639c
src/usage/main.cpp 97f55e9
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated May 17, 2015, 9:38 p.m.)
Review request for mesos and Cody Maloney.
Changes
-------
Fixed missing linux specific raplacements.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/execute.cpp dbd19e6
src/cli/mesos.cpp 171a707
src/cli/resolve.cpp a99b609
src/examples/load_generator_framework.cpp be1a3bf
src/examples/low_level_scheduler_libprocess.cpp bee2e7e
src/examples/low_level_scheduler_pthread.cpp fb8cd66
src/examples/persistent_volume_framework.cpp 8a893fc
src/examples/test_framework.cpp 9f4b53e
src/files/files.cpp ce02411
src/health-check/main.cpp a4ce742
src/launcher/executor.cpp de6f1b1
src/launcher/fetcher.cpp 796526f
src/local/main.cpp a641b9e
src/logging/logging.cpp 6b14575
src/master/main.cpp d5666bc
src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5
src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2
src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5
src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff
src/slave/containerizer/linux_launcher.cpp b9e22e3
src/slave/main.cpp f762f5b
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.hpp b4d91b2
src/tests/fetcher_tests.cpp 4549e6a
src/tests/main.cpp e3fff5d
src/usage/main.cpp 97f55e9
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 34260: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
-----------------------------------------------------------
(Updated May 17, 2015, 9:23 p.m.)
Review request for mesos and Cody Maloney.
Changes
-------
Fixed missing replacement.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
src/cli/execute.cpp dbd19e6
src/cli/mesos.cpp 171a707
src/cli/resolve.cpp a99b609
src/examples/load_generator_framework.cpp be1a3bf
src/examples/low_level_scheduler_libprocess.cpp bee2e7e
src/examples/low_level_scheduler_pthread.cpp fb8cd66
src/examples/persistent_volume_framework.cpp 8a893fc
src/examples/test_framework.cpp 9f4b53e
src/files/files.cpp ce02411
src/health-check/main.cpp a4ce742
src/launcher/executor.cpp de6f1b1
src/launcher/fetcher.cpp 796526f
src/local/main.cpp a641b9e
src/logging/logging.cpp 6b14575
src/master/main.cpp d5666bc
src/slave/containerizer/linux_launcher.cpp b9e22e3
src/slave/main.cpp f762f5b
src/slave/state.hpp fed4b7e
src/slave/state.cpp 8eda22a
src/slave/status_update_manager.hpp b4d91b2
src/tests/fetcher_tests.cpp 4549e6a
src/tests/main.cpp e3fff5d
src/usage/main.cpp 97f55e9
src/zookeeper/group.cpp 173caa8
Diff: https://reviews.apache.org/r/34260/diff/
Testing
-------
make check
Thanks,
Till Toenshoff