[GitHub] [netbeans] BradWalker edited a comment on pull request #3890: Cleanup the use of Float primitive wrapper.

[GitBox <gi...@apache.org>]

BradWalker edited a comment on pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890#issuecomment-1084793313


   > how do you select the sub-projects you are cleaning up? I am wondering if it would be better to continue adding more commits to this PR until it is complete and all types are covered in the files you touched. So that we can review the switch blocks once instead of 8 times :)
   
   Hey @mbien ,
   
   Most of the "rust removal" work that I do, is done to try and make it easy for a reviewer. For example, the "new Float" work this change covers should just be about Floats. I find it easier for me to make changes this way and if I had to review, it makes things easier for me to think in those terms.
   
   Changes required for the "new Double" are going to be really large (i.e. lots of different files). So that really should stand on it's own.
   
   Also, I did try and bundle together the Byte & Short changes since they were reasonable to do and review.
   
   Can I count you as an approver? 8-)
   
   BTW, hang in there.. I'm almost done..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists