You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 15:52:53 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
exceptionfactory opened a new pull request #5276:
URL: https://github.com/apache/nifi/pull/5276
#### Description of PR
NIFI-8990 Upgrades direct dependencies on Groovy 2.5.4 to 2.5.14 in order to address potential vulnerabilities associated with creating temporary directories in extension methods. Additional updates include dependency management version overrides for Hive components, upgrading earlier versions of Groovy to 2.4.21, which also addresses the same potential vulnerabilities. This PR also upgrades TinkerPop Gremlin libraries from 3.3.5 to 3.5.1 in order to update transitive dependencies on Groovy.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #5276:
URL: https://github.com/apache/nifi/pull/5276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #5276:
URL: https://github.com/apache/nifi/pull/5276#issuecomment-892652267
+1 LGTM, thanks for the upgrade (the Tinkerpop stuff was sorely needed!) Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #5276:
URL: https://github.com/apache/nifi/pull/5276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on a change in pull request #5276:
URL: https://github.com/apache/nifi/pull/5276#discussion_r682031489
##########
File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/pom.xml
##########
@@ -85,6 +85,12 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- Override groovy-all:2.1.6 from Hive -->
+ <dependency>
+ <groupId>org.codehaus.groovy</groupId>
+ <artifactId>groovy-all</artifactId>
+ <version>2.4.21</version>
Review comment:
Why are we leaving it at 2.4.X here? Breaking change in 2.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5276:
URL: https://github.com/apache/nifi/pull/5276#discussion_r682035817
##########
File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/pom.xml
##########
@@ -85,6 +85,12 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- Override groovy-all:2.1.6 from Hive -->
+ <dependency>
+ <groupId>org.codehaus.groovy</groupId>
+ <artifactId>groovy-all</artifactId>
+ <version>2.4.21</version>
Review comment:
Thanks for the feedback @MikeThomsen! The main reason for staying with the 2.4 series in the Hive processors was to minimize the impact for those old components. Hive3 depends on Groovy 2.4, the others depend on earlier versions. It is a transitive dependency through `hive-exec`, and it may be acceptable to move up to 2.5, but staying with 2.4 seemed acceptable in this case since it also addresses the underlying issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5276: NIFI-8990 Upgraded Groovy to 2.5.14
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #5276:
URL: https://github.com/apache/nifi/pull/5276#issuecomment-892652267
+1 LGTM, thanks for the upgrade (the Tinkerpop stuff was sorely needed!) Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org