[jira] [Commented] (HDFS-9718) NameNode#initializeGenericKeys don't unset the property while it is not assign on special nnId

["Vinayakumar B (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121507#comment-15121507 ] 

Vinayakumar B commented on HDFS-9718:
-------------------------------------

Good find [~Deng FEI].
But IMO, best place to unset those props is in {{HAUtil.getConfForOtherNodes()}}, as this will not affect the Non-HA mode.

Also, I would recommend to unset only those props which must have different conf in HA environment.
Not all keys mentioned in NAMENODE_SPECIFIC_KEYS must be different. Some can be same too. Those need not be unset. If unset, it might not be reset during initializeGenericKeys.

> NameNode#initializeGenericKeys don't unset the property while it is not assign on special nnId
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9718
>                 URL: https://issues.apache.org/jira/browse/HDFS-9718
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: DENG FEI
>            Assignee: DENG FEI
>         Attachments: HDFS-9718.001.patch, HDFS-9718.002.patch
>
>
> Scenario:
> We want enable NN dfs.namenode.servicerpc-address to separate the client and DN RPC,and do it begin with standby NN--just add the property to standby NN and DNs,when EditLogTailer choose active NN address,it only reset the active NN's nnId generic keys ,but don't unset if not special,so the standby NN choose itself as active NN.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)