You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2009/07/30 00:08:55 UTC
Re: [jexl] svn commit: r799042
On Wed, Jul 29, 2009 at 4:02 PM, <se...@apache.org> wrote:
> Author: sebb
> Date: Wed Jul 29 20:02:42 2009
> New Revision: 799042
>
> URL: http://svn.apache.org/viewvc?rev=799042&view=rev
> Log:
> Add services file for autodiscovery of Jexl script factory
>
> Added:
> commons/proper/jexl/branches/2.0/src/java/META-INF/
<snip/>
Have you tried building the jar? Is the result as desired?
We should really use the standard m2 layout.
Java sources - src/main/java
Resources - src/main/resources (META-INF would go here)
Test sources - src/test/java
etc.
> commons/proper/jexl/branches/2.0/src/java/META-INF/services/
> commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory
>
<snap/>
I guess it makes sense to set eol-style to native here, though I can
understand why it wasn't auto-prop'ed in.
> Added: commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory?rev=799042&view=auto
> ==============================================================================
> --- commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory (added)
> +++ commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory Wed Jul 29 20:02:42 2009
> @@ -0,0 +1,19 @@
> +#
> +# Licensed to the Apache Software Foundation (ASF) under one or more
> +# contributor license agreements. See the NOTICE file distributed with
> +# this work for additional information regarding copyright ownership.
> +# The ASF licenses this file to You under the Apache License, Version 2.0
> +# (the "License"); you may not use this file except in compliance with
> +# the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing, software
> +# distributed under the License is distributed on an "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> +# See the License for the specific language governing permissions and
> +# limitations under the License.
> +#
> +#
> +
> +org.apache.commons.jexl.scripting.JexlScriptEngineFactory
> \ No newline at end of file
>
<snip/>
New line would be better.
I suspect the above factory class is coming at some point then.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by sebb <se...@gmail.com>.
On 30/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Wed, Jul 29, 2009 at 7:39 PM, sebb<se...@gmail.com> wrote:
> > On 30/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> On Wed, Jul 29, 2009 at 7:02 PM, Jörg Schaible<jo...@gmx.de> wrote:
> >> > Rahul Akolkar wrote:
> >> >
> >> > [snip]
> >> >> I have to step out in a minute or two (I can try later), but what I'd
> >> >> try is to make the complete transition to the standard directory
> >> >> layout:
> >> >>
> >> >> 1) Move sources to src/main/java
> >> >>
> >> >> 2) Move tests to src/test/java
> >> >>
> >> >> 3) Remove following from pom:
> >> >> <sourceDirectory>src/java</sourceDirectory>
> >> >> <testSourceDirectory>src/test</testSourceDirectory>
> >> >>
> >> >> 4) Change any bits in the pom that refer to old paths in 1 and 2
> >> >>
> >> >> 5) Build
> >> >
> >> > Resources should be in src/main/resources i.e. there should be
> >> > META-INF/services/javax.script.ScriptEngineFactory
> >> >
> >
> > Done.
> >
> >> <snip/>
> >>
> >> That circles to the top of this thread ;-) Apparently, it still isn't working.
> >
> > This is because of steps 1-3) above not yet having been done.
> >
>
> <snip/>
>
> Got a chance to look at this -- the commons parent pom needs this
> added to the <resources> section:
>
> <resource>
> <directory>src/main/resources</directory>
> </resource>
>
> But that'll mean a parent release etc. Interim, we can add a
> <resources> section to the JEXL pom that matches the one in the
> parent, plus the <resource> above.
>
Yes, it looks like the parent config is overriding the default rather
than adding the new files.
The documentation for the Maven resources plugin is rather unclear on this...
A brief test works fine for me, and is a lot neater than the Ant method.
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jul 29, 2009 at 7:39 PM, sebb<se...@gmail.com> wrote:
> On 30/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> On Wed, Jul 29, 2009 at 7:02 PM, Jörg Schaible<jo...@gmx.de> wrote:
>> > Rahul Akolkar wrote:
>> >
>> > [snip]
>> >> I have to step out in a minute or two (I can try later), but what I'd
>> >> try is to make the complete transition to the standard directory
>> >> layout:
>> >>
>> >> 1) Move sources to src/main/java
>> >>
>> >> 2) Move tests to src/test/java
>> >>
>> >> 3) Remove following from pom:
>> >> <sourceDirectory>src/java</sourceDirectory>
>> >> <testSourceDirectory>src/test</testSourceDirectory>
>> >>
>> >> 4) Change any bits in the pom that refer to old paths in 1 and 2
>> >>
>> >> 5) Build
>> >
>> > Resources should be in src/main/resources i.e. there should be
>> > META-INF/services/javax.script.ScriptEngineFactory
>> >
>
> Done.
>
>> <snip/>
>>
>> That circles to the top of this thread ;-) Apparently, it still isn't working.
>
> This is because of steps 1-3) above not yet having been done.
>
<snip/>
Got a chance to look at this -- the commons parent pom needs this
added to the <resources> section:
<resource>
<directory>src/main/resources</directory>
</resource>
But that'll mean a parent release etc. Interim, we can add a
<resources> section to the JEXL pom that matches the one in the
parent, plus the <resource> above.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by sebb <se...@gmail.com>.
On 30/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Wed, Jul 29, 2009 at 7:02 PM, Jörg Schaible<jo...@gmx.de> wrote:
> > Rahul Akolkar wrote:
> >
> > [snip]
> >> I have to step out in a minute or two (I can try later), but what I'd
> >> try is to make the complete transition to the standard directory
> >> layout:
> >>
> >> 1) Move sources to src/main/java
> >>
> >> 2) Move tests to src/test/java
> >>
> >> 3) Remove following from pom:
> >> <sourceDirectory>src/java</sourceDirectory>
> >> <testSourceDirectory>src/test</testSourceDirectory>
> >>
> >> 4) Change any bits in the pom that refer to old paths in 1 and 2
> >>
> >> 5) Build
> >
> > Resources should be in src/main/resources i.e. there should be
> > META-INF/services/javax.script.ScriptEngineFactory
> >
Done.
> <snip/>
>
> That circles to the top of this thread ;-) Apparently, it still isn't working.
This is because of steps 1-3) above not yet having been done.
>
> -Rahul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jul 29, 2009 at 7:02 PM, Jörg Schaible<jo...@gmx.de> wrote:
> Rahul Akolkar wrote:
>
> [snip]
>> I have to step out in a minute or two (I can try later), but what I'd
>> try is to make the complete transition to the standard directory
>> layout:
>>
>> 1) Move sources to src/main/java
>>
>> 2) Move tests to src/test/java
>>
>> 3) Remove following from pom:
>> <sourceDirectory>src/java</sourceDirectory>
>> <testSourceDirectory>src/test</testSourceDirectory>
>>
>> 4) Change any bits in the pom that refer to old paths in 1 and 2
>>
>> 5) Build
>
> Resources should be in src/main/resources i.e. there should be
> META-INF/services/javax.script.ScriptEngineFactory
>
<snip/>
That circles to the top of this thread ;-) Apparently, it still isn't working.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by Jörg Schaible <jo...@gmx.de>.
Rahul Akolkar wrote:
[snip]
> I have to step out in a minute or two (I can try later), but what I'd
> try is to make the complete transition to the standard directory
> layout:
>
> 1) Move sources to src/main/java
>
> 2) Move tests to src/test/java
>
> 3) Remove following from pom:
> <sourceDirectory>src/java</sourceDirectory>
> <testSourceDirectory>src/test</testSourceDirectory>
>
> 4) Change any bits in the pom that refer to old paths in 1 and 2
>
> 5) Build
Resources should be in src/main/resources i.e. there should be
META-INF/services/javax.script.ScriptEngineFactory
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jul 29, 2009 at 6:42 PM, sebb<se...@gmail.com> wrote:
> On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> On Wed, Jul 29, 2009 at 6:26 PM, sebb<se...@gmail.com> wrote:
>> > On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> >> On Wed, Jul 29, 2009 at 4:02 PM, <se...@apache.org> wrote:
>> >> > Author: sebb
>> >> > Date: Wed Jul 29 20:02:42 2009
>> >> > New Revision: 799042
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=799042&view=rev
>> >> > Log:
>> >> > Add services file for autodiscovery of Jexl script factory
>> >> >
>> >> > Added:
>> >> > commons/proper/jexl/branches/2.0/src/java/META-INF/
>> >> <snip/>
>> >>
>> >> Have you tried building the jar? Is the result as desired?
>> >
>> > Yes.
>> >
>> > I had to add an Ant task to copy the file
>> >
>>
>> <snip/>
>>
>> Right, moving to standard will leave the pom much cleaner.
>
> I tried removing the Ant copy task, but then the build does not copy
> the services file across. Not sure ehat's wrong.
>
<snip/>
I have to step out in a minute or two (I can try later), but what I'd
try is to make the complete transition to the standard directory
layout:
1) Move sources to src/main/java
2) Move tests to src/test/java
3) Remove following from pom:
<sourceDirectory>src/java</sourceDirectory>
<testSourceDirectory>src/test</testSourceDirectory>
4) Change any bits in the pom that refer to old paths in 1 and 2
5) Build
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by sebb <se...@gmail.com>.
On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Wed, Jul 29, 2009 at 6:26 PM, sebb<se...@gmail.com> wrote:
> > On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> On Wed, Jul 29, 2009 at 4:02 PM, <se...@apache.org> wrote:
> >> > Author: sebb
> >> > Date: Wed Jul 29 20:02:42 2009
> >> > New Revision: 799042
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=799042&view=rev
> >> > Log:
> >> > Add services file for autodiscovery of Jexl script factory
> >> >
> >> > Added:
> >> > commons/proper/jexl/branches/2.0/src/java/META-INF/
> >> <snip/>
> >>
> >> Have you tried building the jar? Is the result as desired?
> >
> > Yes.
> >
> > I had to add an Ant task to copy the file
> >
>
> <snip/>
>
> Right, moving to standard will leave the pom much cleaner.
I tried removing the Ant copy task, but then the build does not copy
the services file across. Not sure ehat's wrong.
> Once you drop what you have now in place, lets move things around and
> clean up the pom.
>
>
> -Rahul
>
>
>
> >> We should really use the standard m2 layout.
> >>
> >> Java sources - src/main/java
> >> Resources - src/main/resources (META-INF would go here)
> >
> > OK.
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jul 29, 2009 at 6:26 PM, sebb<se...@gmail.com> wrote:
> On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> On Wed, Jul 29, 2009 at 4:02 PM, <se...@apache.org> wrote:
>> > Author: sebb
>> > Date: Wed Jul 29 20:02:42 2009
>> > New Revision: 799042
>> >
>> > URL: http://svn.apache.org/viewvc?rev=799042&view=rev
>> > Log:
>> > Add services file for autodiscovery of Jexl script factory
>> >
>> > Added:
>> > commons/proper/jexl/branches/2.0/src/java/META-INF/
>> <snip/>
>>
>> Have you tried building the jar? Is the result as desired?
>
> Yes.
>
> I had to add an Ant task to copy the file
>
<snip/>
Right, moving to standard will leave the pom much cleaner.
Once you drop what you have now in place, lets move things around and
clean up the pom.
-Rahul
>> We should really use the standard m2 layout.
>>
>> Java sources - src/main/java
>> Resources - src/main/resources (META-INF would go here)
>
> OK.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] svn commit: r799042
Posted by sebb <se...@gmail.com>.
On 29/07/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Wed, Jul 29, 2009 at 4:02 PM, <se...@apache.org> wrote:
> > Author: sebb
> > Date: Wed Jul 29 20:02:42 2009
> > New Revision: 799042
> >
> > URL: http://svn.apache.org/viewvc?rev=799042&view=rev
> > Log:
> > Add services file for autodiscovery of Jexl script factory
> >
> > Added:
> > commons/proper/jexl/branches/2.0/src/java/META-INF/
> <snip/>
>
> Have you tried building the jar? Is the result as desired?
Yes.
I had to add an Ant task to copy the file
> We should really use the standard m2 layout.
>
> Java sources - src/main/java
> Resources - src/main/resources (META-INF would go here)
OK.
> Test sources - src/test/java
>
> etc.
>
>
> > commons/proper/jexl/branches/2.0/src/java/META-INF/services/
> > commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory
> >
> <snap/>
>
> I guess it makes sense to set eol-style to native here, though I can
> understand why it wasn't auto-prop'ed in.
Oops!
>
> > Added: commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory
> > URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory?rev=799042&view=auto
> > ==============================================================================
> > --- commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory (added)
> > +++ commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory Wed Jul 29 20:02:42 2009
> > @@ -0,0 +1,19 @@
> > +#
> > +# Licensed to the Apache Software Foundation (ASF) under one or more
> > +# contributor license agreements. See the NOTICE file distributed with
> > +# this work for additional information regarding copyright ownership.
> > +# The ASF licenses this file to You under the Apache License, Version 2.0
> > +# (the "License"); you may not use this file except in compliance with
> > +# the License. You may obtain a copy of the License at
> > +#
> > +# http://www.apache.org/licenses/LICENSE-2.0
> > +#
> > +# Unless required by applicable law or agreed to in writing, software
> > +# distributed under the License is distributed on an "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > +# See the License for the specific language governing permissions and
> > +# limitations under the License.
> > +#
> > +#
> > +
> > +org.apache.commons.jexl.scripting.JexlScriptEngineFactory
> > \ No newline at end of file
> >
> <snip/>
>
> New line would be better.
Will do.
> I suspect the above factory class is coming at some point then.
Yes, and the engine. Just finishing up the code.
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org