You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by pi...@apache.org on 2021/10/01 12:51:06 UTC

[atlas] 01/02: ATLAS-4441:#2 UI , Regression, Business Metadata : Unable to add alphanumeric to BM attribute of type string, fixed

This is an automated email from the ASF dual-hosted git repository.

pinal pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/atlas.git

commit dbdc4225706ff40b0bc1a81a6d8cdc4a93fe53ae
Author: prasad pawar <pr...@freestoneinfotech.com>
AuthorDate: Fri Oct 1 11:16:38 2021 +0530

    ATLAS-4441:#2 UI , Regression, Business Metadata : Unable to add alphanumeric to BM attribute of type string, fixed
    
    Signed-off-by: Pinal Shah <pi...@freestoneinfotech.com>
---
 .../js/views/business_metadata/CreateBusinessMetadataLayoutView.js      | 2 +-
 dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js    | 2 +-
 dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js        | 2 +-
 .../js/views/business_metadata/CreateBusinessMetadataLayoutView.js      | 2 +-
 dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js    | 2 +-
 dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js        | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js b/dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
index 4957002..21bb663 100644
--- a/dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
+++ b/dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
@@ -292,7 +292,7 @@ define(['require',
                         data: this.json,
                         success: function(model, response) {
                             Utils.notifySuccess({
-                                content: "One or more Business Metadada attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
+                                content: "One or more Business Metadata attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
                             });
                             if (model.businessMetadataDefs && model.businessMetadataDefs.length) {
                                 that.selectedBusinessMetadata.set(model.businessMetadataDefs[0]);
diff --git a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
index 254c8ac..ff28506 100644
--- a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
+++ b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
@@ -233,7 +233,7 @@ define(['require',
                             multiple: selectEl.data("multi"),
                             createTag: function(params) {
                                 var option = params.term;
-                                if ($.isNumeric(option)) {
+                                if ($.isNumeric(option) || (typeName === "array<string>" && _.isString(option))) {
                                     return {
                                         id: option,
                                         text: option
diff --git a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js
index 3e61f3a..213e7cc 100644
--- a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js
+++ b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js
@@ -191,7 +191,7 @@ define([
                 type: "POST",
                 success: function(data) {
                     Utils.notifySuccess({
-                        content: "One or more Business Metadada attributes" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
+                        content: "One or more Business Metadata attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
                     });
                     that.entity.businessAttributes = data;
                     that.ui.businessMetadataTree.html("");
diff --git a/dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js b/dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
index 4957002..21bb663 100644
--- a/dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
+++ b/dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
@@ -292,7 +292,7 @@ define(['require',
                         data: this.json,
                         success: function(model, response) {
                             Utils.notifySuccess({
-                                content: "One or more Business Metadada attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
+                                content: "One or more Business Metadata attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
                             });
                             if (model.businessMetadataDefs && model.businessMetadataDefs.length) {
                                 that.selectedBusinessMetadata.set(model.businessMetadataDefs[0]);
diff --git a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
index 5202d01..913cc0f 100644
--- a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
+++ b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
@@ -234,7 +234,7 @@ define(['require',
                             multiple: selectEl.data("multi"),
                             createTag: function(params) {
                                 var option = params.term;
-                                if ($.isNumeric(option)) {
+                                if ($.isNumeric(option) || (typeName === "array<string>" && _.isString(option))) {
                                     return {
                                         id: option,
                                         text: option
diff --git a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js
index 0735cf4..81db893 100644
--- a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js
+++ b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js
@@ -191,7 +191,7 @@ define([
                 type: "POST",
                 success: function(data) {
                     Utils.notifySuccess({
-                        content: "One or more Business Metadada attributes" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
+                        content: "One or more Business Metadata attribute" + Messages.getAbbreviationMsg(true, 'editSuccessMessage')
                     });
                     that.entity.businessAttributes = data;
                     that.ui.businessMetadataTree.html("");