You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/18 12:51:24 UTC

[GitHub] [hudi] SteNicholas commented on a diff in pull request #6976: [HUDI-5042]fix clustering schedule problem in flink

SteNicholas commented on code in PR #6976:
URL: https://github.com/apache/hudi/pull/6976#discussion_r998167542


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/ClusteringPlanActionExecutor.java:
##########
@@ -56,35 +57,36 @@ public ClusteringPlanActionExecutor(HoodieEngineContext context,
     this.extraMetadata = extraMetadata;
   }
 
-  protected Option<HoodieClusteringPlan> createClusteringPlan() {
+  protected boolean getIfScheduleClustering(HoodieActiveTimeline activeTimeline) {

Review Comment:
   ```suggestion
     protected boolean isScheduleClustering(HoodieActiveTimeline activeTimeline) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org