You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/07/27 12:53:19 UTC
Re: [PR] fix: ExplainNode guard against NULL planstate on QE [cloudberry]
Copilot commented on code in PR #1865:
URL: https://github.com/apache/cloudberry/pull/1865#discussion_r3657224383
##########
src/backend/commands/explain.c:
##########
@@ -1557,6 +1557,14 @@ ExplainNode(PlanState *planstate, List *ancestors,
int motion_recv;
int motion_snd;
ExecSlice *parentSlice = NULL;
+ /*
+ * Guard if subtree on QE lives in another slice
+ * and not instantiated here.
+ */
+ if (planstate == NULL)
+ return;
+
Review Comment:
The new guard comment has trailing whitespace (`/* `) and the wording is a bit unclear/grammatically off compared with nearby comments. Rewording it into the standard multi-line comment style (and removing trailing spaces) will keep the file consistent and avoid whitespace-only diffs later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org