svn commit: r1390114 - /maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java

[ol...@apache.org]

Author: olamy
Date: Tue Sep 25 20:33:14 2012
New Revision: 1390114

URL: http://svn.apache.org/viewvc?rev=1390114&view=rev
Log:
more generics

Modified:
    maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java

Modified: maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java?rev=1390114&r1=1390113&r2=1390114&view=diff
==============================================================================
--- maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java (original)
+++ maven/plugins/trunk/maven-stage-plugin/src/main/java/org/apache/maven/plugins/stage/DefaultRepositoryCopier.java Tue Sep 25 20:33:14 2012
@@ -114,15 +114,14 @@ public class DefaultRepositoryCopier
 
         logger.info( "Looking for files in the source repository." );
 
-        List files = new ArrayList();
+        List<String> files = new ArrayList<String>();
 
         scan( sourceWagon, "", files );
 
         logger.info( "Downloading files from the source repository to: " + basedir );
 
-        for ( Iterator i = files.iterator(); i.hasNext(); )
+        for ( String s : files )
         {
-            String s = (String) i.next();
 
             if ( s.indexOf( ".svn" ) >= 0 )
             {
@@ -459,11 +458,11 @@ public class DefaultRepositoryCopier
 
     private void scan( Wagon wagon,
                        String basePath,
-                       List collected )
+                       List<String> collected )
     {
         try
         {
-            List files = wagon.getFileList( basePath );
+            List<String> files = wagon.getFileList( basePath );
 
             if ( files.isEmpty() )
             {
@@ -472,9 +471,8 @@ public class DefaultRepositoryCopier
             else
             {
                 basePath = basePath + "/";
-                for ( Iterator iterator = files.iterator(); iterator.hasNext(); )
+                for ( String file : files )
                 {
-                    String file = (String) iterator.next();
                     logger.info( "Found file in the source repository: " + file );
                     scan( wagon, basePath + file, collected );
                 }
@@ -496,15 +494,15 @@ public class DefaultRepositoryCopier
 
     }
 
-    protected List scanForArtifactPaths( ArtifactRepository repository )
+    protected List<String> scanForArtifactPaths( ArtifactRepository repository )
     {
-        List collected;
+        List<String> collected;
         try
         {
             Wagon wagon = wagonManager.getWagon( repository.getProtocol() );
             Repository artifactRepository = new Repository( repository.getId(), repository.getUrl() );
             wagon.connect( artifactRepository );
-            collected = new ArrayList();
+            collected = new ArrayList<String>();
             scan( wagon, "/", collected );
             wagon.disconnect();