You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/05/05 08:53:47 UTC
[PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
slawekjaranowski opened a new pull request, #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237#discussion_r1590267152
##########
src/it/MINVOKER-335-symlinks-in-source/selector.groovy:
##########
@@ -28,7 +28,12 @@ def testFile = projectPath.resolve('test.txt')
Files.createDirectory(testDir)
Files.createFile(testFile)
-Files.createSymbolicLink(projectPath.resolve('testDirLink'), Paths.get('testDir'))
-Files.createSymbolicLink(projectPath.resolve('testLink.txt'), Paths.get('test.txt'))
+// if FS not supports symlinks - we should skip test
Review Comment:
If FS does not support symlinks we should skip test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237#issuecomment-2957823977
Resolve #566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237#discussion_r1590271101
##########
src/it/MINVOKER-335-symlinks-in-source/selector.groovy:
##########
@@ -28,7 +28,12 @@ def testFile = projectPath.resolve('test.txt')
Files.createDirectory(testDir)
Files.createFile(testFile)
-Files.createSymbolicLink(projectPath.resolve('testDirLink'), Paths.get('testDir'))
-Files.createSymbolicLink(projectPath.resolve('testLink.txt'), Paths.get('test.txt'))
+// if FS not supports symlinks - we should skip test
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org