[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

["Grant Ingersoll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753634#action_12753634 ] 

Grant Ingersoll commented on SOLR-1221:
---------------------------------------

Looks good to me, the only oddity is the name of the testPhraseHighlighter now tests the non-phrase highlighter.

Also, testing wise, do we now risk losing tests for the other highlighter?  I'm not that familiar with the phrase highlighter, so maybe all it does is subsume the functionality of the old one and add phrase support, in which case the existing tests are fine.  If it does not do that, though, it seems like we might want to duplicate the tests, with use phrase highlighter set to false for the dups.  Unless, of course, you think the existing single test that turns off the phrase highlighter is sufficient.

> Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-1221
>                 URL: https://issues.apache.org/jira/browse/SOLR-1221
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 1.4
>
>         Attachments: SOLR-1221.patch
>
>
> To improve the out of the box experience of Solr 1.4, I really think we should make this change. You will still be able to turn both off.
> Comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.