You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Cliff Jansen <cl...@gmail.com> on 2013/01/24 09:30:21 UTC
Review Request: part 3 of gcc flags for C++ compatibility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
Description
-------
gcc flag "-sign-compare" that provides c++ checking
This addresses bug proton-159.
https://issues.apache.org/jira/browse/proton-159
Diffs
-----
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762
Diff: https://reviews.apache.org/r/9086/diff/
Testing
-------
compiles on linux and runs proton test. Along with other patches, also compiles in Visual Studio.
Thanks,
Cliff Jansen
Re: Review Request: part 3 of gcc flags for C++ compatibility
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/#review15701
-----------------------------------------------------------
Ship it!
Ship It!
- Kenneth Giusti
On Jan. 24, 2013, 8:30 a.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9086/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 8:30 a.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> gcc flag "-sign-compare" that provides c++ checking
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762
>
> Diff: https://reviews.apache.org/r/9086/diff/
>
>
> Testing
> -------
>
> compiles on linux and runs proton test. Along with other patches, also compiles in Visual Studio.
>
>
> Thanks,
>
> Cliff Jansen
>
>
Re: Review Request: part 3 of gcc flags for C++ compatibility
Posted by Mary Hinton <m....@nc.rr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/#review15668
-----------------------------------------------------------
Ship it!
Ship It!
- Mary Hinton
On Jan. 24, 2013, 8:30 a.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9086/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 8:30 a.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> gcc flag "-sign-compare" that provides c++ checking
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762
>
> Diff: https://reviews.apache.org/r/9086/diff/
>
>
> Testing
> -------
>
> compiles on linux and runs proton test. Along with other patches, also compiles in Visual Studio.
>
>
> Thanks,
>
> Cliff Jansen
>
>
Re: Review Request: part 3 of gcc flags for C++ compatibility
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/#review15769
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On Jan. 24, 2013, 8:30 a.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9086/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 8:30 a.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> gcc flag "-sign-compare" that provides c++ checking
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762
>
> Diff: https://reviews.apache.org/r/9086/diff/
>
>
> Testing
> -------
>
> compiles on linux and runs proton test. Along with other patches, also compiles in Visual Studio.
>
>
> Thanks,
>
> Cliff Jansen
>
>
Re: Review Request: part 3 of gcc flags for C++ compatibility
Posted by Cliff Jansen <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/
-----------------------------------------------------------
(Updated Jan. 24, 2013, 8:30 a.m.)
Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
Description
-------
gcc flag "-sign-compare" that provides c++ checking
This addresses bug proton-159.
https://issues.apache.org/jira/browse/proton-159
Diffs
-----
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762
Diff: https://reviews.apache.org/r/9086/diff/
Testing
-------
compiles on linux and runs proton test. Along with other patches, also compiles in Visual Studio.
Thanks,
Cliff Jansen