Re: [PR] Simplify bytes arrays in NumericLeafComparator to long [lucene]

["jpountz (via GitHub)" <gi...@apache.org>]

jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1549312756


##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -85,6 +82,10 @@ public void disableSkipping() {
     pruning = Pruning.NONE;
   }
 
+  protected abstract long missingValueAsComparableLong();
+
+  protected abstract long sortableBytesToLong(byte[] bytes);

Review Comment:
   Can you add minimal javadocs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org