[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7421:
URL: https://github.com/apache/iceberg/pull/7421#discussion_r1176013227


##########
core/src/main/java/org/apache/iceberg/view/ViewVersionParser.java:
##########
@@ -42,7 +43,7 @@ static void toJson(ViewVersion version, JsonGenerator generator) throws IOExcept
 
     generator.writeNumberField(VERSION_ID, version.versionId());
     generator.writeNumberField(TIMESTAMP_MS, version.timestampMillis());
-
+    generator.writeNumberField(SCHEMA_ID, version.schemaId());

Review Comment:
   nit: we should probably not remove the newline before starting to write summary part



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org