You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/04/03 08:29:33 UTC
Review Request 58137: Added `mesos config show` command to display the
config file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs
-----
src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/58137/diff/1/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 58137: Added `mesos config show` command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review170849
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57896, 57951, 57952, 58137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 3, 2017, 8:29 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 8:29 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58137/diff/1/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review171632
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57896, 57951, 57952, 58137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 11, 2017, 2:53 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 2:53 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58137/diff/3/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review173675
-----------------------------------------------------------
src/cli_new/lib/cli/plugins/config/main.py
Lines 87 (patched)
<https://reviews.apache.org/r/58137/#comment246703>
We shoud use the syntax where we name the placeholder instead of leaving it anonymous, i.e.:
```
sys.stdout.write("{stream}\n".format(stream=stream.read().rstrip()))
```
- Kevin Klues
On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:21 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
>
>
> Diff: https://reviews.apache.org/r/58137/diff/6/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review176265
-----------------------------------------------------------
Looks like this needs a rebase after the new `config.py` library addition.
- Kevin Klues
On May 4, 2017, 9:39 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 9:39 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
>
>
> Diff: https://reviews.apache.org/r/58137/diff/7/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review173996
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57896, 57951, 58381, 57952, 58137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 4, 2017, 9:39 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 9:39 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
>
>
> Diff: https://reviews.apache.org/r/58137/diff/7/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command in the
new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review176275
-----------------------------------------------------------
Fix it, then Ship it!
src/cli_new/lib/cli/plugins/config/main.py
Lines 96-97 (patched)
<https://reviews.apache.org/r/58137/#comment249643>
The space at the end of the first line should be at the beginning of the second line. I will make this change myself before committing.
- Kevin Klues
On May 29, 2017, 3:46 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 3:46 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py 6e19e5c2e148b92323a6ea0e9a7610eb938a84d9
>
>
> Diff: https://reviews.apache.org/r/58137/diff/8/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command in the
new Mesos CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
(Updated May 29, 2017, 3:46 p.m.)
Review request for mesos, Joseph Wu and Kevin Klues.
Changes
-------
The code has been rebased and improved now that we have a Config class.
Summary (updated)
-----------------
Added 'mesos config show' command in the new Mesos CLI.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs (updated)
-----
src/cli_new/lib/cli/plugins/config/main.py 6e19e5c2e148b92323a6ea0e9a7610eb938a84d9
Diff: https://reviews.apache.org/r/58137/diff/8/
Changes: https://reviews.apache.org/r/58137/diff/7-8/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
(Updated May 4, 2017, 9:39 p.m.)
Review request for mesos, Joseph Wu and Kevin Klues.
Changes
-------
Fixed issues raised in comments.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs (updated)
-----
src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
Diff: https://reviews.apache.org/r/58137/diff/7/
Changes: https://reviews.apache.org/r/58137/diff/6-7/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review173664
-----------------------------------------------------------
src/cli_new/lib/cli/plugins/config/main.py
Lines 83-84 (patched)
<https://reviews.apache.org/r/58137/#comment246685>
You need to check that this file exists and raise an appropriate CLIException if it does not.
- Kevin Klues
On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:21 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
>
>
> Diff: https://reviews.apache.org/r/58137/diff/6/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review171868
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57896, 57951, 58381, 57952, 58137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:21 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58137/diff/5/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: CLI: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review172005
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57896, 57951, 58381, 57952, 58137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:21 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7
>
>
> Diff: https://reviews.apache.org/r/58137/diff/6/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review171765
-----------------------------------------------------------
Bad patch!
Reviews applied: [58137, 57952, 58381]
Failed command: python support/apply-reviews.py -n -r 57952
Error:
2017-04-12 18:03:31 URL:https://reviews.apache.org/r/57952/diff/raw/ [4208/4208] -> "57952.patch" [1]
error: patch failed: src/cli_new/bin/settings.py:40
error: src/cli_new/bin/settings.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17742/console
- Mesos Reviewbot
On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:21 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58137/diff/4/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
(Updated April 12, 2017, 9:21 a.m.)
Review request for mesos, Joseph Wu and Kevin Klues.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs (updated)
-----
src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/58137/diff/4/
Changes: https://reviews.apache.org/r/58137/diff/3-4/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
(Updated April 11, 2017, 2:53 p.m.)
Review request for mesos, Joseph Wu and Kevin Klues.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs (updated)
-----
src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/58137/diff/3/
Changes: https://reviews.apache.org/r/58137/diff/2-3/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review171423
-----------------------------------------------------------
Bad patch!
Reviews applied: [58137, 57952, 57951, 57896]
Failed command: python support/apply-reviews.py -n -r 57951
Error:
2017-04-10 07:38:52 URL:https://reviews.apache.org/r/57951/diff/raw/ [5127/5127] -> "57951.patch" [1]
error: patch failed: src/cli_new/bin/settings.py:20
error: src/cli_new/bin/settings.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17708/console
- Mesos Reviewbot
On April 10, 2017, 12:08 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 12:08 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the contents of the user-defined config.toml file.
>
>
> Diffs
> -----
>
> src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58137/diff/2/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58137: Added 'mesos config show' command to
display the config file.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/
-----------------------------------------------------------
(Updated April 10, 2017, 6:38 a.m.)
Review request for mesos, Joseph Wu and Kevin Klues.
Summary (updated)
-----------------
Added 'mesos config show' command to display the config file.
Repository: mesos
Description
-------
This command displays the contents of the user-defined config.toml file.
Diffs (updated)
-----
src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/58137/diff/2/
Changes: https://reviews.apache.org/r/58137/diff/1-2/
Testing
-------
Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
Thanks,
Armand Grillet