You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/02 16:38:50 UTC

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------




src/cli/execute.cpp (line 283)
<https://reviews.apache.org/r/44441/#comment189700>

    How to handle those command parameters contains "," here? For example, if user want to try "cat 'a,b'".


- haosdent huang


On March 31, 2016, 1:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > <https://reviews.apache.org/r/44441/diff/3/?file=1320213#file1320213line283>
> >
> >     How to handle those command parameters contains "," here? For example, if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
>     Yeah, and if the user wants "echo 'hello world'"? I'm fine with consolidating command and arguments flag, but let's make sure we parse it correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", "arg2", ...]`; we can leverage our JSON parser for this, I believe `tockenize()` is not enough. Also, I would like us manually test various inputs and capture them in the testing done section. We may later want to automate these tests in a staging cluster.
> 
> Guangya Liu wrote:
>     Yes, I will test more cases. 
>     
>     @haosdent, for your case, you should run the command as `--command="cat,/etc/passwd,/etc/passwd"`
>     
>     @Alexr, does the strings::tokenize(command.get(), ",") enough? Why need JSON parser?

@alexr, one question for your comments above:

`I.e. ["command", "arg1", "arg2", ...]; we can leverage our JSON parser for this`

Do you mean using JSON parser parse the `["command", "arg1", "arg2", ...]`? I think that the JSON does not support such format. What about enable `command` flag set the following JSON:

{
"command" : "cmd",
"args": "["arg1", "arg2", "arg3,arg3"]"
}


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0000
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
>  
> 7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command=""I0413 10:45:13.365993 18037 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '0cae04e2-e47a-4297-86c3-e370e95fa350-0001'
> Submitted task 'test_mesos' to agent '0cae04e2-e47a-4297-86c3-e370e95fa350-S0'
> Received status update TASK_RUNNING for task 'test_mesos'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > <https://reviews.apache.org/r/44441/diff/3/?file=1320213#file1320213line283>
> >
> >     How to handle those command parameters contains "," here? For example, if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
>     Yeah, and if the user wants "echo 'hello world'"? I'm fine with consolidating command and arguments flag, but let's make sure we parse it correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", "arg2", ...]`; we can leverage our JSON parser for this, I believe `tockenize()` is not enough. Also, I would like us manually test various inputs and capture them in the testing done section. We may later want to automate these tests in a staging cluster.

Yes, I will test more cases. 

@haosdent, for your case, you should run the command as `--command="cat,/etc/passwd,/etc/passwd"`

@Alexr, does the strings::tokenize(command.get(), ",") enough? Why need JSON parser?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On 四月 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > <https://reviews.apache.org/r/44441/diff/3/?file=1320213#file1320213line283>
> >
> >     How to handle those command parameters contains "," here? For example, if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
>     Yeah, and if the user wants "echo 'hello world'"? I'm fine with consolidating command and arguments flag, but let's make sure we parse it correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", "arg2", ...]`; we can leverage our JSON parser for this, I believe `tockenize()` is not enough. Also, I would like us manually test various inputs and capture them in the testing done section. We may later want to automate these tests in a staging cluster.
> 
> Guangya Liu wrote:
>     Yes, I will test more cases. 
>     
>     @haosdent, for your case, you should run the command as `--command="cat,/etc/passwd,/etc/passwd"`
>     
>     @Alexr, does the strings::tokenize(command.get(), ",") enough? Why need JSON parser?
> 
> Guangya Liu wrote:
>     @alexr, one question for your comments above:
>     
>     `I.e. ["command", "arg1", "arg2", ...]; we can leverage our JSON parser for this`
>     
>     Do you mean using JSON parser parse the `["command", "arg1", "arg2", ...]`? I think that the JSON does not support such format. What about enable `command` flag set the following JSON:
>     
>     {
>     "command" : "cmd",
>     "args": "["arg1", "arg2", "arg3,arg3"]"
>     }

Alex, any comments for this? I was blocked here and want to get some comments from you. Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0000
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
>  
> 7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command=""I0413 10:45:13.365993 18037 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '0cae04e2-e47a-4297-86c3-e370e95fa350-0001'
> Submitted task 'test_mesos' to agent '0cae04e2-e47a-4297-86c3-e370e95fa350-S0'
> Received status update TASK_RUNNING for task 'test_mesos'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Posted by haosdent huang <ha...@gmail.com>.

> On April 2, 2016, 2:38 p.m., haosdent huang wrote:
> >

By the way, use comma "," as delimiter looks a bit wired. Usually we use space or tab " ", right?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On March 31, 2016, 1:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On April 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > <https://reviews.apache.org/r/44441/diff/3/?file=1320213#file1320213line283>
> >
> >     How to handle those command parameters contains "," here? For example, if user want to try "cat 'a,b'".

Yeah, and if the user wants "echo 'hello world'"? I'm fine with consolidating command and arguments flag, but let's make sure we parse it correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", "arg2", ...]`; we can leverage our JSON parser for this, I believe `tockenize()` is not enough. Also, I would like us manually test various inputs and capture them in the testing done section. We may later want to automate these tests in a staging cluster.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126690
-----------------------------------------------------------


On April 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>