You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Qifan Pu (JIRA)" <ji...@apache.org> on 2016/08/05 21:49:20 UTC
[jira] [Created] (SPARK-16928) Recursive call of
ColumnVector::getInt() breaks JIT inlining
Qifan Pu created SPARK-16928:
--------------------------------
Summary: Recursive call of ColumnVector::getInt() breaks JIT inlining
Key: SPARK-16928
URL: https://issues.apache.org/jira/browse/SPARK-16928
Project: Spark
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Qifan Pu
In both OnHeapColumnVector and OffHeapColumnVector, we implemented getInt() with the following code pattern:
public int getInt(int rowId) {
if (dictionary == null) {
return intData[rowId];
} else {
return dictionary.decodeToInt(dictionaryIds.getInt(rowId));
}
}
As dictionaryIds is also a ColumnVector, this results in a recursive call of getInt() and breaks JIT inlining. As a result, getInt() will not get inlined.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org