[PR] syslog/channel: rename syslog_channel() to syslog_channel_register() [nuttx]

["anchao (via GitHub)" <gi...@apache.org>]

anchao opened a new pull request, #13571:
URL: https://github.com/apache/nuttx/pull/13571

   ## Summary
   
   syslog/channel: rename syslog_channel() to syslog_channel_register()
   
   Change syslog API naming more reasonable:
   
   1. rename syslog_channel() to syslog_channel_register()
   2. rename syslog_channel_remove() to syslog_channel_unregister()
   
   Signed-off-by: chao an <an...@lixiang.com>
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] syslog/channel: rename syslog_channel() to syslog_channel_register() [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13571:
URL: https://github.com/apache/nuttx/pull/13571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] syslog/channel: rename syslog_channel() to syslog_channel_register() [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13571:
URL: https://github.com/apache/nuttx/pull/13571#issuecomment-2367097583

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This PR appears to meet the basic NuttX requirements, but it's missing some key information:
   
   **Summary:**
   
   * **Why change is necessary?**  The summary mentions making the naming "more reasonable," but doesn't explain why the current naming is unreasonable or what benefits the new naming brings. 
   * **What functional part of the code is being changed?**  While "syslog/channel" is mentioned, a slightly more detailed description of this part of the codebase would be helpful.
   
   **Impact:**
   
   * While marking everything as "N/A" might be technically correct, it's best to be explicit.  For example:
       * **Impact on user:**  Will users need to update their applications to use the new function names? If so, is this change backwards compatible?
       * **Impact on documentation:** Even if the changes are small, the documentation likely needs updating to reflect the new function names.
   
   **Testing:**
   
   * **"ci-check" is not enough information.**  Provide details about the build host(s) and target(s) used for testing.
   * **Include relevant testing logs before and after the change.** This helps demonstrate the issue the PR addresses and proves that the change works as intended. 
   
   **In short, the PR needs more context and details to be considered complete.** 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org