You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 19:02:18 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
MaxGekk opened a new pull request #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973
### What changes were proposed in this pull request?
In the PR, I propose to refactor reading of timestamps of the `TIMESTAMP_MILLIS` logical type from Parquet files in `VectorizedColumnReader`, and move checking of the `rebaseDateTime` flag out of the internal loop.
### Why are the changes needed?
To avoid any additional overhead of the checking the SQL config `spark.sql.legacy.parquet.rebaseDateTime.enabled` introduced by the PR https://github.com/apache/spark/pull/27915.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By running the test suite `ParquetIOSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601947050
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601867129
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601866648
**[Test build #120115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120115/testReport)** for PR 27973 at commit [`5012060`](https://github.com/apache/spark/commit/50120608897b22fb13ed05f975941e492d215af3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601867139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24828/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601867129
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601866648
**[Test build #120115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120115/testReport)** for PR 27973 at commit [`5012060`](https://github.com/apache/spark/commit/50120608897b22fb13ed05f975941e492d215af3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601947053
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120115/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601864418
ping @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601947053
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120115/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601947050
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601867139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24828/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-602615118
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#issuecomment-601946660
**[Test build #120115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120115/testReport)** for PR 27973 at commit [`5012060`](https://github.com/apache/spark/commit/50120608897b22fb13ed05f975941e492d215af3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27973:
[SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out
of the loop in `VectorizedColumnReader`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27973: [SPARK-31159][SQL][FOLLOWUP] Move checking of the `rebaseDateTime` flag out of the loop in `VectorizedColumnReader`
URL: https://github.com/apache/spark/pull/27973#discussion_r396473005
##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -462,15 +462,22 @@ private void readLongBatch(int rowId, int num, WritableColumnVector column) thro
num, column, rowId, maxDefLevel, (VectorizedValuesReader) dataColumn);
}
} else if (originalType == OriginalType.TIMESTAMP_MILLIS) {
- for (int i = 0; i < num; i++) {
- if (defColumn.readInteger() == maxDefLevel) {
- long micros = DateTimeUtils.millisToMicros(dataColumn.readLong());
- if (rebaseDateTime) {
- micros = DateTimeUtils.rebaseJulianToGregorianMicros(micros);
+ if (rebaseDateTime) {
Review comment:
I am kind of neutral but a bit of dups vs a bit of perf :-). I guess it's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org