You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/01 17:54:55 UTC
Re: Review Request 19007: Added log implementation for state storage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19007/#review39167
-----------------------------------------------------------
Ship it!
src/tests/state_tests.cpp
<https://reviews.apache.org/r/19007/#comment71527>
This can be killed now:)
- Jie Yu
On March 31, 2014, 7:11 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19007/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 7:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a combination of both https://reviews.apache.org/r/17423 and https://reviews.apache.org/r/17424 which have been merged to make it easier to make changes.
>
>
> Diffs
> -----
>
> src/Makefile.am 47d03b393f68ebd4e9eba3206798a939078023c0
> src/messages/state.proto 7f7a8a505d6f24b01fec0c3ad47b0e15b2b17ffa
> src/state/log.hpp PRE-CREATION
> src/state/log.cpp PRE-CREATION
> src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
>
> Diff: https://reviews.apache.org/r/19007/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 19007: Added log implementation for state storage.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 1, 2014, 3:54 p.m., Jie Yu wrote:
> > src/tests/state_tests.cpp, lines 586-594
> > <https://reviews.apache.org/r/19007/diff/1-2/?file=515953#file515953line586>
> >
> > This can be killed now:)
Yes sir, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19007/#review39167
-----------------------------------------------------------
On March 31, 2014, 7:11 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19007/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 7:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a combination of both https://reviews.apache.org/r/17423 and https://reviews.apache.org/r/17424 which have been merged to make it easier to make changes.
>
>
> Diffs
> -----
>
> src/Makefile.am 47d03b393f68ebd4e9eba3206798a939078023c0
> src/messages/state.proto 7f7a8a505d6f24b01fec0c3ad47b0e15b2b17ffa
> src/state/log.hpp PRE-CREATION
> src/state/log.cpp PRE-CREATION
> src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
>
> Diff: https://reviews.apache.org/r/19007/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>