You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/17 16:35:17 UTC

Review Request 33311: Ambari Upgrade from 1.7.0 to 2.0.0 fails to restart ZK server due to missing symlink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33311/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-10566
    https://issues.apache.org/jira/browse/AMBARI-10566


Repository: ambari


Description
-------

Ambari upgrade from 1.7.0 to 2.0.0 had problems on starting/restarting zookeeper server because /usr/hdp/current/zookeeper-server symlink was not found. The customer remedied the issue by calling "hdp-select set zookeeper-server 2.2.3.0-###" on all of the hosts, which created the symlink.
In Ambari 1.7.0, ZK server was started using the libs from ZK client, so as part of the Ambari Upgrade, we need to first call "hdp-select set zookeeper-server
{version}
"
It's possible that the either exactly one of start/restart command will handle this. Need to verify what the behavior is.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 2680851 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py a3136d3 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py 4bd94bc 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py b2946f4 
  ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 61b3f40 

Diff: https://reviews.apache.org/r/33311/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [1.759s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.740s]
[INFO] Ambari Server ..................................... SUCCESS [37.253s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40.428s
[INFO] Finished at: Fri Apr 17 17:34:36 EEST 2015
[INFO] Final Memory: 41M/463M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 33311: Ambari Upgrade from 1.7.0 to 2.0.0 fails to restart ZK server due to missing symlink

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33311/#review80747
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On April 20, 2015, 1:52 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33311/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 1:52 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-10566
>     https://issues.apache.org/jira/browse/AMBARI-10566
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari upgrade from 1.7.0 to 2.0.0 had problems on starting/restarting zookeeper server because /usr/hdp/current/zookeeper-server symlink was not found. The customer remedied the issue by calling "hdp-select set zookeeper-server 2.2.3.0-###" on all of the hosts, which created the symlink.
> In Ambari 1.7.0, ZK server was started using the libs from ZK client, so as part of the Ambari Upgrade, we need to first call "hdp-select set zookeeper-server
> {version}
> "
> It's possible that the either exactly one of start/restart command will handle this. Need to verify what the behavior is.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 1e35327 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 2680851 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py a3136d3 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py 4bd94bc 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py b2946f4 
>   ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 61b3f40 
> 
> Diff: https://reviews.apache.org/r/33311/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [1.759s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.740s]
> [INFO] Ambari Server ..................................... SUCCESS [37.253s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40.428s
> [INFO] Finished at: Fri Apr 17 17:34:36 EEST 2015
> [INFO] Final Memory: 41M/463M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 33311: Ambari Upgrade from 1.7.0 to 2.0.0 fails to restart ZK server due to missing symlink

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33311/
-----------------------------------------------------------

(Updated April 20, 2015, 1:52 p.m.)


Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-10566
    https://issues.apache.org/jira/browse/AMBARI-10566


Repository: ambari


Description
-------

Ambari upgrade from 1.7.0 to 2.0.0 had problems on starting/restarting zookeeper server because /usr/hdp/current/zookeeper-server symlink was not found. The customer remedied the issue by calling "hdp-select set zookeeper-server 2.2.3.0-###" on all of the hosts, which created the symlink.
In Ambari 1.7.0, ZK server was started using the libs from ZK client, so as part of the Ambari Upgrade, we need to first call "hdp-select set zookeeper-server
{version}
"
It's possible that the either exactly one of start/restart command will handle this. Need to verify what the behavior is.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 1e35327 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 2680851 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py a3136d3 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py 4bd94bc 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py b2946f4 
  ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 61b3f40 

Diff: https://reviews.apache.org/r/33311/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [1.759s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.740s]
[INFO] Ambari Server ..................................... SUCCESS [37.253s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40.428s
[INFO] Finished at: Fri Apr 17 17:34:36 EEST 2015
[INFO] Final Memory: 41M/463M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 33311: Ambari Upgrade from 1.7.0 to 2.0.0 fails to restart ZK server due to missing symlink

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33311/#review80493
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
<https://reviews.apache.org/r/33311/#comment130428>

    Can you add a comment indicating why this was needed. Also, can this accept a parameter on whether configure() was called as part of a rolling restart so that we also check that rolling_restart is False.


- Alejandro Fernandez


On April 17, 2015, 2:35 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33311/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 2:35 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-10566
>     https://issues.apache.org/jira/browse/AMBARI-10566
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari upgrade from 1.7.0 to 2.0.0 had problems on starting/restarting zookeeper server because /usr/hdp/current/zookeeper-server symlink was not found. The customer remedied the issue by calling "hdp-select set zookeeper-server 2.2.3.0-###" on all of the hosts, which created the symlink.
> In Ambari 1.7.0, ZK server was started using the libs from ZK client, so as part of the Ambari Upgrade, we need to first call "hdp-select set zookeeper-server
> {version}
> "
> It's possible that the either exactly one of start/restart command will handle this. Need to verify what the behavior is.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 2680851 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py a3136d3 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py 4bd94bc 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py b2946f4 
>   ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 61b3f40 
> 
> Diff: https://reviews.apache.org/r/33311/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [1.759s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.740s]
> [INFO] Ambari Server ..................................... SUCCESS [37.253s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40.428s
> [INFO] Finished at: Fri Apr 17 17:34:36 EEST 2015
> [INFO] Final Memory: 41M/463M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>