You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 01:44:25 UTC

[GitHub] [arrow-rs] HaoYang670 opened a new pull request #1349: Add `async` to default features

HaoYang670 opened a new pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349


   Signed-off-by: remzi <13...@gmail.com>
   
   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1307.
   
   # Rationale for this change
    
    <!---
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   Add `async` to default enabled features, so that the link `arrow::async_reader` is active.
   <!---
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!---
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` into doc features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1059947985


   Thanks @HaoYang670  -- I am trying to test this change using a local docs.rs build -- https://github.com/rust-lang/docs.rs/blob/master/README.md#build-subcommand 
   
   WIll report how it goes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1055086839


   Thank you for your review! I will update my PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1349: Add `async` into doc features

Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1061287006


   > I wasn't able to get the local docs.rs build to work and then ran out of time ;( Hopefully we'll get this into the next arrow release (it missed the cutoff for 10.0.0 sadly)
   
   Thanks a lot @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1055162599


   Neither `all_features = true` nor `features = ["default", "async"]` works on my desktop. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1055399394


   > > Neither all_features = true nor features = ["default", "async"] works on my desktop.
   > 
   > Can you share what you tried? Perhaps the output of `git diff` ?
   
   I add
   ```
   [package.metadata.docs.rs]
   all_features = true
   ```
   in parquet/Cargo.toml.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` into doc features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1083555381


   FWIW I have tried several times to build docs.rs on my laptop and have not had any luck for some reason. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1057086145


   🤔 I haven't had a chance to really test, but it looks like docs.rs has some specific build process (that isn't just `cargo doc`) https://docs.rs/about/builds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1047353602


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1349](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0814078) into [master](https://codecov.io/gh/apache/arrow-rs/commit/89ee9acf01b5b9895596a3843212076ce82c9b00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89ee9ac) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/1349/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1349   +/-   ##
   =======================================
     Coverage   83.03%   83.03%           
   =======================================
     Files         181      181           
     Lines       52936    52936           
   =======================================
   + Hits        43955    43958    +3     
   + Misses       8981     8978    -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `84.52% <0.00%> (+0.13%)` | :arrow_up: |
   | [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
   | [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1349/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (+0.39%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [89ee9ac...0814078](https://codecov.io/gh/apache/arrow-rs/pull/1349?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1055340833


   > Neither all_features = true nor features = ["default", "async"] works on my desktop.
   
   Can you share what you tried? Perhaps the output of `git diff` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` into doc features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1061149099


   I wasn't able to get the local docs.rs build to work and then ran out of time ;( Hopefully we'll get this into the next arrow release (it missed the cutoff for 10.0.0 sadly)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` into doc features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1083555667


   I am wary of merging this in without testing it as it might cause the docs.rs build to fail 😭 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1349: Add `async` to default features

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1349:
URL: https://github.com/apache/arrow-rs/pull/1349#issuecomment-1054655018


   THank you @HaoYang670 
   
   Changing the default features of the arrow crate may have some non trivial downstream consequences for users of arrow.
   
   What would you think about just updating the metadata for the docs.rs build following https://docs.rs/about/metadata? Perhaps something like:
   
   ```yml
   [package.metadata.docs.rs]
   
   # Whether to pass `--all-features` to Cargo (default: false)
   all-features = true
   ```
   
   ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org