You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 16:43:42 UTC

[GitHub] [spark] gatorsmile commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan should show the table name on UI

gatorsmile commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan should show the table name on UI
URL: https://github.com/apache/spark/pull/24534#discussion_r281263848
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ##########
 @@ -36,6 +36,10 @@ case class InMemoryTableScanExec(
     @transient relation: InMemoryRelation)
   extends LeafExecNode with ColumnarBatchScan {
 
+  override val nodeName: String = {
+    s"Scan in memory table ${relation.cacheBuilder.tableName.map(_.replace("`", "")).getOrElse("")}"
 
 Review comment:
   Here, `memory table` is misleading to end users, if the cached data does not correspond to a table. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org