You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/21 20:36:45 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
pkarashchenko opened a new pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309
## Summary
Some toolchains may be built without libm support, but using such toochains should not generate any errors in case if math functions are not used in the program
## Impact
Enable toolchains without libm support
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020763140
@pkarashchenko after this PR, when I locally run this command I get errors:
```
➜ nuttx git:(6c27f3c19d) tools/testbuild.sh -j 100 -e '-Wno-cpp -Werror' tools/ci/testlist/arm-01.dat
====================================================================================
Configuration/Tool: pcduino-a10/nsh,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
Disabling CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: warning: ‘-mcpu=’ is deprecated; use ‘-mtune=’ or ‘-march=’ instead
```
any ideas what's going on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020793633
I will need to take a look closer to this today to find out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020933896
@AlanRosenthal the root cause of an issue is that you are running `tools/testbuild.sh` without `-l` flag. The default `pcduino-a10/nsh` config is `CONFIG_HOST_WINDOWS=y` that is why things are getting messy.
But is it good that you pointed out
```
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
Disabling CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
```
We should not use `CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL` for ARMv7-A based boards. I will correct that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020793633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020797977
> ```
> ./tools/configure.sh pcduino-a10/nsh -j 1
> kconfig-tweak --file /home/alanrosenthal/code/nuttx/nuttx/../nuttx/.config -d CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
> kconfig-tweak --file /home/alanrosenthal/code/nuttx/nuttx/../nuttx/.config -e CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> make -k EXTRAFLAGS="-Wno-cpp -Werror" -j 1 olddefconfig
> ```
> steps to repro
What is the toolchain version that you are using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020786692
```
./tools/configure.sh pcduino-a10/nsh -j 1
kconfig-tweak --file /home/alanrosenthal/code/nuttx/nuttx/../nuttx/.config -d CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
kconfig-tweak --file /home/alanrosenthal/code/nuttx/nuttx/../nuttx/.config -e CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
make -k EXTRAFLAGS="-Wno-cpp -Werror" -j 1 olddefconfig
```
steps to repro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal commented on pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020763140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5309: toolchain: add libm to EXTRA_LIBS only if it is provided by the compiler
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org