You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/18 21:03:15 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #5121: Fixing pattern matching for binding patterns
matthiasblaesing opened a new pull request, #5121:
URL: https://github.com/apache/netbeans/pull/5121
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5121: Fixing pattern matching for binding patterns
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5121:
URL: https://github.com/apache/netbeans/pull/5121#issuecomment-1358332997
@jlahoda this is an updated version of your PR #3342. The fix was pending and began to bitrot. As I think I triggered it and it was already reviewed by @jtulach I had a look and checked if I could fix the problems. I think I succeeded. Could you please double check?
@mbien you touched the tests so would be nice if you could also have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5121: Fixing pattern matching for binding patterns
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5121:
URL: https://github.com/apache/netbeans/pull/5121#issuecomment-1360066123
Thank you for the review. Lets get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5121: Fixing pattern matching for binding patterns
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5121:
URL: https://github.com/apache/netbeans/pull/5121#discussion_r1053461558
##########
java/spi.java.hints/test/unit/src/org/netbeans/modules/java/hints/spiimpl/UtilitiesTest.java:
##########
@@ -380,9 +380,9 @@ public void testCasePattern() throws Exception {
String golden = "case $expr: foo bar; $stmts$; ";
assertEquals(golden.replaceAll("[ \n\r]+", " "), result.toString().replaceAll("[ \n\r]+", " "));
assertDiagnostics(errors, "19-19:compiler.err.expected");
- assertPositions(result, positions[0], code, "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar ");
+ assertPositions(result, positions[0], code, "$expr", "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar ");
}
-*/
Review Comment:
awesome. Good to see this test case enabled.
I wanted to do that in:
https://github.com/apache/netbeans/pull/5107#discussion_r1047673049
when we enabled tests for this module (and many others) which was completely turned off till now.
but I wasn't sure if the result was actually correct. So I commented it out instead of running the risk to commit a wrong test assumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #5121: Fixing pattern matching for binding patterns
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #5121:
URL: https://github.com/apache/netbeans/pull/5121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists