[GitHub] [pulsar] eolivelli commented on a diff in pull request #16313: [improve][broker] Make `unloadNamespaceBundle` async.

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #16313:
URL: https://github.com/apache/pulsar/pull/16313#discussion_r912940019


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -736,14 +736,20 @@ public BundlesData getBundlesData(@PathParam("property") String property, @PathP
             @ApiResponse(code = 412, message = "Namespace is already unloaded or Namespace has bundles activated")})
     public void unloadNamespace(@Suspended final AsyncResponse asyncResponse, @PathParam("property") String property,
             @PathParam("cluster") String cluster, @PathParam("namespace") String namespace) {
-        try {
-            validateNamespaceName(property, cluster, namespace);
-            internalUnloadNamespace(asyncResponse);
-        } catch (WebApplicationException wae) {
-            asyncResponse.resume(wae);
-        } catch (Exception e) {
-            asyncResponse.resume(new RestException(e));
-        }
+        validateNamespaceName(property, cluster, namespace);

Review Comment:
   why aren't we wrapping this into a try/catch block as before ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org