You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/02/05 22:30:29 UTC
[commons-lang] branch master updated: Use try-with-resources
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new a82463650 Use try-with-resources
a82463650 is described below
commit a824636506707706b888d2784e47b57f788bb47e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Feb 5 17:23:19 2023 -0500
Use try-with-resources
---
.../apache/commons/lang3/text/StrBuilderTest.java | 80 +++++++++++-----------
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java b/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java
index 6552ed7ed..0ebf53c21 100644
--- a/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java
@@ -1600,59 +1600,61 @@ public class StrBuilderTest extends AbstractLangTest {
reader.close();
assertTrue(reader.ready());
- final Reader r = sb.asReader();
- final char[] arr = new char[3];
- assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, -1, 0));
- assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 0, -1));
- assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 100, 1));
- assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 0, 100));
- assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, Integer.MAX_VALUE, Integer.MAX_VALUE));
-
- assertEquals(0, r.read(arr, 0, 0));
- assertEquals(0, arr[0]);
- assertEquals(0, arr[1]);
- assertEquals(0, arr[2]);
-
- r.skip(9);
- assertEquals(-1, r.read(arr, 0, 1));
-
- r.reset();
- array = new char[30];
- assertEquals(9, r.read(array, 0, 30));
+ try (Reader r = sb.asReader()) {
+ final char[] arr = new char[3];
+ assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, -1, 0));
+ assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 0, -1));
+ assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 100, 1));
+ assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, 0, 100));
+ assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, Integer.MAX_VALUE, Integer.MAX_VALUE));
+
+ assertEquals(0, r.read(arr, 0, 0));
+ assertEquals(0, arr[0]);
+ assertEquals(0, arr[1]);
+ assertEquals(0, arr[2]);
+
+ r.skip(9);
+ assertEquals(-1, r.read(arr, 0, 1));
+
+ r.reset();
+ array = new char[30];
+ assertEquals(9, r.read(array, 0, 30));
+ }
}
@Test
public void testAsWriter() throws Exception {
final StrBuilder sb = new StrBuilder("base");
- final Writer writer = sb.asWriter();
+ try (Writer writer = sb.asWriter()) {
- writer.write('l');
- assertEquals("basel", sb.toString());
+ writer.write('l');
+ assertEquals("basel", sb.toString());
- writer.write(new char[] {'i', 'n'});
- assertEquals("baselin", sb.toString());
+ writer.write(new char[] { 'i', 'n' });
+ assertEquals("baselin", sb.toString());
- writer.write(new char[] {'n', 'e', 'r'}, 1, 2);
- assertEquals("baseliner", sb.toString());
+ writer.write(new char[] { 'n', 'e', 'r' }, 1, 2);
+ assertEquals("baseliner", sb.toString());
- writer.write(" rout");
- assertEquals("baseliner rout", sb.toString());
+ writer.write(" rout");
+ assertEquals("baseliner rout", sb.toString());
- writer.write("ping that server", 1, 3);
- assertEquals("baseliner routing", sb.toString());
+ writer.write("ping that server", 1, 3);
+ assertEquals("baseliner routing", sb.toString());
- writer.flush(); // no effect
- assertEquals("baseliner routing", sb.toString());
+ writer.flush(); // no effect
+ assertEquals("baseliner routing", sb.toString());
- writer.close(); // no effect
- assertEquals("baseliner routing", sb.toString());
+ writer.close(); // no effect
+ assertEquals("baseliner routing", sb.toString());
- writer.write(" hi"); // works after close
- assertEquals("baseliner routing hi", sb.toString());
+ writer.write(" hi"); // works after close
+ assertEquals("baseliner routing hi", sb.toString());
- sb.setLength(4); // mix and match
- writer.write('d');
- assertEquals("based", sb.toString());
+ sb.setLength(4); // mix and match
+ writer.write('d');
+ assertEquals("based", sb.toString());
+ }
}
@Test