[GitHub] [camel] davsclaus commented on a change in pull request #5556: CAMEL-16537 Allow to define connection via uri params

[GitBox <gi...@apache.org>]

davsclaus commented on a change in pull request #5556:
URL: https://github.com/apache/camel/pull/5556#discussion_r631781795



##########
File path: components/camel-mongodb/src/main/java/org/apache/camel/component/mongodb/MongoDbEndpoint.java
##########
@@ -68,6 +69,13 @@
     @UriPath(description = "Sets the connection bean reference used to lookup a client for connecting to a database.")
     @Metadata(required = true)
     private String connectionBean;
+
+    @UriParam

Review comment:
       (label = security, secret = true)

##########
File path: components/camel-mongodb/src/main/java/org/apache/camel/component/mongodb/MongoDbEndpoint.java
##########
@@ -68,6 +69,13 @@
     @UriPath(description = "Sets the connection bean reference used to lookup a client for connecting to a database.")
     @Metadata(required = true)
     private String connectionBean;
+
+    @UriParam
+    private String username;
+    @UriParam

Review comment:
       (label = security, secret = true)
   
   to have username and password as security options and also as secret so they are not leaked in logs etc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org