You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/10/12 23:53:51 UTC

[GitHub] [tinkerpop] divijvaidya opened a new pull request #1347: Tinkerpop-2437 Do not leave statusAttributes future dangling

divijvaidya opened a new pull request #1347:
URL: https://github.com/apache/tinkerpop/pull/1347


   https://issues.apache.org/jira/browse/TINKERPOP-2437
   
   ##Motivation
   We do not complete the statusAttribute future if the underlying `readCompleted` is completed exceptionally.
   
   ##Testing
   grenlin-server `mvn clean install -DskipIntegrationTests=false -DincludeNeo4j`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] divijvaidya merged pull request #1347: Tinkerpop-2437 Do not leave statusAttributes future dangling

Posted by GitBox <gi...@apache.org>.
divijvaidya merged pull request #1347:
URL: https://github.com/apache/tinkerpop/pull/1347


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1347: Tinkerpop-2437 Do not leave statusAttributes future dangling

Posted by GitBox <gi...@apache.org>.
divijvaidya commented on a change in pull request #1347:
URL: https://github.com/apache/tinkerpop/pull/1347#discussion_r516178125



##########
File path: CHANGELOG.asciidoc
##########
@@ -48,6 +48,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 * Server now supports WebSocket compression extension ([RFC7692](https://tools.ietf.org/html/rfc7692)).
 * Fixed bug with Bytecode serialization when `Bytecode.toString()` is used in Javascript.
 * Fixed "toString" for P and TextP to produce valid script representation from bytecode glv steps containing a string predicate in Javascript.
+* Fix bug which could cause Java driver to hang when using `ResultSet.statusAttributes()`

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1347: Tinkerpop-2437 Do not leave statusAttributes future dangling

Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1347:
URL: https://github.com/apache/tinkerpop/pull/1347#discussion_r509591073



##########
File path: CHANGELOG.asciidoc
##########
@@ -48,6 +48,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 * Server now supports WebSocket compression extension ([RFC7692](https://tools.ietf.org/html/rfc7692)).
 * Fixed bug with Bytecode serialization when `Bytecode.toString()` is used in Javascript.
 * Fixed "toString" for P and TextP to produce valid script representation from bytecode glv steps containing a string predicate in Javascript.
+* Fix bug which could cause Java driver to hang when using `ResultSet.statusAttributes()`

Review comment:
       nit: "Fixed" rather than "Fix" - we try to stick to a past tense with changelog entries. might want to quickly clean up a few of those "now supports" and "now delegates" above too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1347: Tinkerpop-2437 Do not leave statusAttributes future dangling

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1347:
URL: https://github.com/apache/tinkerpop/pull/1347#issuecomment-713811240


   Minor nit in review for changelog but other than that VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org