[GitHub] [spark] yaooqinn commented on a change in pull request #27672: [SPARK-30919][SQL] Make interval multiply and divide's overflow behavior consistent with other operations

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #27672: [SPARK-30919][SQL] Make interval multiply and divide's overflow behavior consistent with other operations
URL: https://github.com/apache/spark/pull/27672#discussion_r383656155
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
 ##########
 @@ -113,12 +114,14 @@ object ExtractIntervalPart {
 abstract class IntervalNumOperation(
     interval: Expression,
     num: Expression,
-    operation: (CalendarInterval, Double) => CalendarInterval,
-    operationName: String)
+    val checkOverflow: Boolean = SQLConf.get.ansiEnabled)
 
 Review comment:
   Isn't  `SQLConf.get`  thread-safe? or `set command` can take effect across spark sessions? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org