You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/05 08:48:08 UTC

[GitHub] [spark] wangyum opened a new pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

wangyum opened a new pull request #28734:
URL: https://github.com/apache/spark/pull/28734


   ### What changes were proposed in this pull request?
   
   This pr normalize all binary comparison expressions when comparing plans.
   
   ### Why are the changes needed?
   
   Improve test framework, otherwise this test will fail:
   ```scala
     test("SPARK-31912 Normalize all binary comparison expressions") {
       val original = testRelation
         .where('a === 'b && Literal(13) >= 'b).as("x")
       val optimized = testRelation
         .where(IsNotNull('a) && IsNotNull('b) && 'a === 'b && 'b <= 13 && 'a <= 13).as("x")
       comparePlans(Optimize.execute(original.analyze), optimized.analyze)
     }
   ```
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639486062






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639484919


   **[Test build #123557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123557/testReport)** for PR 28734 at commit [`dbc4614`](https://github.com/apache/spark/commit/dbc4614b95832b9ba58fb0b798a5e120065ef6be).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639350434






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639349983


   **[Test build #123557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123557/testReport)** for PR 28734 at commit [`dbc4614`](https://github.com/apache/spark/commit/dbc4614b95832b9ba58fb0b798a5e120065ef6be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-643079877


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-641355129


   I encountered this issue when inferring from inequality attributes before, Its order may change:
   https://github.com/apache/spark/blob/bfa60393789673b1cd77fbda038cdc8c17c1a866/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala#L402-L407


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639350434






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639486062






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-641319075






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum closed pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #28734:
URL: https://github.com/apache/spark/pull/28734


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28734: [SPARK-31912][SQL][TESTS] Normalize all binary comparison expressions

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-639349983


   **[Test build #123557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123557/testReport)** for PR 28734 at commit [`dbc4614`](https://github.com/apache/spark/commit/dbc4614b95832b9ba58fb0b798a5e120065ef6be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org