How to commit rule changes?

[Karsten Bräckelmann <gu...@rudersport.de>]

Awesome, now I am thoroughly confused. How exactly am I supposed to
commit rule changes?

While doing the RTC dance for bug 6467 [1], an additional(?) commit for
the update channel has been mentioned. Is that still necessary, or does
committing to the 3.3 branch suffice?

Also, while looking at the diffs, I found bug 6406 never has been
committed to the branch, only trunk -- despite the fact there actually
was a call for votes. Which is only required for the branch in RTC mode,
not trunk (currently in CTR mode). No?

  guenther


[1] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6467
[2] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6406

-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}

Re: How to commit rule changes?

[Karsten Bräckelmann <gu...@rudersport.de>]

On Sat, 2010-07-24 at 20:05 -0400, Daryl C. W. O'Shea wrote:
> I will attempt to take a look at a way to do a non-automatic update of
> 3.3 in the next couple of days.
> 
> Normally, you'd commit the rule to trunk and it'd show up in the stable
> update after passing QA.  Problem is, though, we haven't had enough
> mass-check results lately for that to happen.

So for rule changes, that would effectively be the opposite of code
changes? :/  Code changes are CTR in trunk (commit, then review), and
RTC for stable branches.

With sufficient mass-check results, my recent rule changes (trunk only)
would have been published already, without any review?


> On 23/07/2010 9:52 AM, Karsten Bräckelmann wrote:
> > Awesome, now I am thoroughly confused. How exactly am I supposed to
> > commit rule changes?

Sic. Now even more.

> > While doing the RTC dance for bug 6467 [1], an additional(?) commit for
> > the update channel has been mentioned. Is that still necessary, or does
> > committing to the 3.3 branch suffice?
> > 
> > Also, while looking at the diffs, I found bug 6406 never has been
> > committed to the branch, only trunk -- despite the fact there actually
> > was a call for votes. Which is only required for the branch in RTC mode,
> > not trunk (currently in CTR mode). No?

> > [1] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6467
> > [2] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6406

-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}

Re: How to commit rule changes?

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

I will attempt to take a look at a way to do a non-automatic update of
3.3 in the next couple of days.

Normally, you'd commit the rule to trunk and it'd show up in the stable
update after passing QA.  Problem is, though, we haven't had enough
mass-check results lately for that to happen.

Daryl


On 23/07/2010 9:52 AM, Karsten Bräckelmann wrote:
> Awesome, now I am thoroughly confused. How exactly am I supposed to
> commit rule changes?
> 
> While doing the RTC dance for bug 6467 [1], an additional(?) commit for
> the update channel has been mentioned. Is that still necessary, or does
> committing to the 3.3 branch suffice?
> 
> Also, while looking at the diffs, I found bug 6406 never has been
> committed to the branch, only trunk -- despite the fact there actually
> was a call for votes. Which is only required for the branch in RTC mode,
> not trunk (currently in CTR mode). No?
> 
>   guenther
> 
> 
> [1] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6467
> [2] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6406
>