You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/22 10:51:04 UTC
[GitHub] [nifi] adenes opened a new pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
adenes opened a new pull request #5238:
URL: https://github.com/apache/nifi/pull/5238
Added the component name to the "Configure Processor", "Configure Controller Service" and "Configure Reporting Task" dialogs' title bar.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes commented on a change in pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
adenes commented on a change in pull request #5238:
URL: https://github.com/apache/nifi/pull/5238#discussion_r675345019
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.css
##########
@@ -72,17 +72,28 @@
height: 56px;
background-color: #728E9B;
overflow: hidden;
-}
-
-.dialog-header-text {
color: #fff;
font-size: 18px;
font-family: 'Roboto Slab';
font-style: normal;
font-weight: bold;
- line-height: 56px;
- padding-left: 20px;
text-overflow: ellipsis;
+ line-height: 56px;
+ padding: 0 20px;
+ white-space: nowrap;
+}
+
+.dialog-header-text {
+}
Review comment:
Thanks @mtien-apache for the review, I have removed this block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5238:
URL: https://github.com/apache/nifi/pull/5238#issuecomment-885807602
Merging based on @mtien-apache and @gresockj reviews and since the failed build is unrelated to the change itself. Thanks for this improvement @adenes, this is super useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #5238:
URL: https://github.com/apache/nifi/pull/5238#issuecomment-885155654
Reviewing now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5238:
URL: https://github.com/apache/nifi/pull/5238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on a change in pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on a change in pull request #5238:
URL: https://github.com/apache/nifi/pull/5238#discussion_r675160392
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.css
##########
@@ -72,17 +72,28 @@
height: 56px;
background-color: #728E9B;
overflow: hidden;
-}
-
-.dialog-header-text {
color: #fff;
font-size: 18px;
font-family: 'Roboto Slab';
font-style: normal;
font-weight: bold;
- line-height: 56px;
- padding-left: 20px;
text-overflow: ellipsis;
+ line-height: 56px;
+ padding: 0 20px;
+ white-space: nowrap;
+}
+
+.dialog-header-text {
+}
Review comment:
Suggestion to remove the style declaration block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #5238: NIFI-8937 Show component name and version in configure dialog's title bar
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #5238:
URL: https://github.com/apache/nifi/pull/5238#issuecomment-885796782
@adenes The changes look good! Unfortunately, the CI build didn't pass. Once that passes I can approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org