[GitHub] [superset] betodealmeida commented on a change in pull request #19423: fix: Remove`time_range_endpoints` from query context object

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #19423:
URL: https://github.com/apache/superset/pull/19423#discussion_r838881405



##########
File path: superset/migrations/versions/2ed890b36b94_rm_time_range_endpoints_from_qc.py
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""rm_time_range_endpoints_from_qc
+
+Revision ID: 2ed890b36b94
+Revises: 58df9d617f14
+Create Date: 2022-03-29 18:03:48.977741
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "2ed890b36b94"
+down_revision = "58df9d617f14"
+
+import json
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects import postgresql
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+Base = declarative_base()
+
+
+class Slice(Base):
+    __tablename__ = "slices"
+    id = sa.Column(sa.Integer, primary_key=True)
+    query_context = sa.Column(sa.Text)
+
+
+def upgrade():
+    bind = op.get_bind()
+    session = db.Session(bind=bind)
+    for slc in session.query(Slice):
+        if slc.query_context:
+            try:
+                query_context = json.loads(slc.query_context)
+                queries = query_context.get("queries")
+                for query in queries:
+                    query.get("extras", {}).pop("time_range_endpoints", None)
+                slc.queries = json.dumps(queries)
+            except json.decoder.JSONDecodeError:
+                pass

Review comment:
       In general it's better to keep the try/except block as small as needed:
   
   ```suggestion
               try:
                   query_context = json.loads(slc.query_context)
               except json.decoder.JSONDecodeError:
                   continue
               queries = query_context.get("queries")
               for query in queries:
                   query.get("extras", {}).pop("time_range_endpoints", None)
               slc.queries = json.dumps(queries)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org