[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #47: setup publishing to apache nexus

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #47:
URL: https://github.com/apache/incubator-pekko-http/pull/47#issuecomment-1429691004

   > > lgtm. Will also need to add the `DISCLAIMER` file using the sbt-apache-sonatype plugin similarly to how it was done with pekko-core but that can be done seperately.
   > 
   > That already seems to be working out of the box!?
   
   Its implemented manually in https://github.com/apache/incubator-pekko-http/blob/main/project/MetaInfLicenseNoticeCopy.scala#L16-L29 but sbt-apache-sonatype handles this for you as well, see https://github.com/apache/incubator-pekko/blob/main/project/AddMetaInfLicenseFiles.scala#L18-L42 (note that `apacheSonatypeDisclaimerFile` is optional)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org